summaryrefslogtreecommitdiffstats
path: root/extensions/renderer/dom_activity_logger.h
diff options
context:
space:
mode:
authoravi <avi@chromium.org>2015-09-24 22:05:23 -0700
committerCommit bot <commit-bot@chromium.org>2015-09-25 05:06:40 +0000
commitaae26eee1748e1f4d69dcb669487a6d204a8057e (patch)
tree53e7bcefdfd3bd75e0a6b68a129cc25b6c6f6b93 /extensions/renderer/dom_activity_logger.h
parentb9d559afaa999e9b3c9a0ae95b46aff43c9dbc4c (diff)
downloadchromium_src-aae26eee1748e1f4d69dcb669487a6d204a8057e.zip
chromium_src-aae26eee1748e1f4d69dcb669487a6d204a8057e.tar.gz
chromium_src-aae26eee1748e1f4d69dcb669487a6d204a8057e.tar.bz2
Enforce marking "override" for functions overriding Blink in extensions/.
BUG=535367 TEST=it all stays working Review URL: https://codereview.chromium.org/1370443005 Cr-Commit-Position: refs/heads/master@{#350772}
Diffstat (limited to 'extensions/renderer/dom_activity_logger.h')
-rw-r--r--extensions/renderer/dom_activity_logger.h36
1 files changed, 18 insertions, 18 deletions
diff --git a/extensions/renderer/dom_activity_logger.h b/extensions/renderer/dom_activity_logger.h
index 13dfd42..c9979e5 100644
--- a/extensions/renderer/dom_activity_logger.h
+++ b/extensions/renderer/dom_activity_logger.h
@@ -33,7 +33,7 @@ class DOMActivityLogger: public blink::WebDOMActivityLogger {
public:
static const int kMainWorldId = 0;
explicit DOMActivityLogger(const std::string& extension_id);
- virtual ~DOMActivityLogger();
+ ~DOMActivityLogger() override;
// Check (using the WebKit API) if there is no logger attached to the world
// corresponding to world_id, and if so, construct a new logger and attach it.
@@ -48,28 +48,28 @@ class DOMActivityLogger: public blink::WebDOMActivityLogger {
// log.
// These methods don't have the override keyword due to the complexities it
// introduces when changes blink apis.
- virtual void logGetter(const blink::WebString& api_name,
- const blink::WebURL& url,
- const blink::WebString& title);
- virtual void logSetter(const blink::WebString& api_name,
- const v8::Local<v8::Value>& new_value,
- const blink::WebURL& url,
- const blink::WebString& title);
+ void logGetter(const blink::WebString& api_name,
+ const blink::WebURL& url,
+ const blink::WebString& title) override;
+ void logSetter(const blink::WebString& api_name,
+ const v8::Local<v8::Value>& new_value,
+ const blink::WebURL& url,
+ const blink::WebString& title) override;
virtual void logSetter(const blink::WebString& api_name,
const v8::Local<v8::Value>& new_value,
const v8::Local<v8::Value>& old_value,
const blink::WebURL& url,
const blink::WebString& title);
- virtual void logMethod(const blink::WebString& api_name,
- int argc,
- const v8::Local<v8::Value>* argv,
- const blink::WebURL& url,
- const blink::WebString& title);
- virtual void logEvent(const blink::WebString& event_name,
- int argc,
- const blink::WebString* argv,
- const blink::WebURL& url,
- const blink::WebString& title);
+ void logMethod(const blink::WebString& api_name,
+ int argc,
+ const v8::Local<v8::Value>* argv,
+ const blink::WebURL& url,
+ const blink::WebString& title) override;
+ void logEvent(const blink::WebString& event_name,
+ int argc,
+ const blink::WebString* argv,
+ const blink::WebURL& url,
+ const blink::WebString& title) override;
// Helper function to actually send the message across IPC.
void SendDomActionMessage(const std::string& api_call,