diff options
| author | dewittj <dewittj@chromium.org> | 2016-03-15 13:49:40 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-15 20:52:45 +0000 |
| commit | 0bfd25d460a1cff98f9f0573a0d6cc072ecbe359 (patch) | |
| tree | 7ab48054430a4554246176f08a4d6c4045c63240 /extensions/renderer/guest_view | |
| parent | 04c8fd5e7c57f75262f477e6ac94e18ca76b6371 (diff) | |
| download | chromium_src-0bfd25d460a1cff98f9f0573a0d6cc072ecbe359.zip chromium_src-0bfd25d460a1cff98f9f0573a0d6cc072ecbe359.tar.gz chromium_src-0bfd25d460a1cff98f9f0573a0d6cc072ecbe359.tar.bz2 | |
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of https://codereview.chromium.org/1769273004/ )
Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for Linux (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/26678) Windows (https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46875) and Mac
Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}
Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>
Also reverts https://codereview.chromium.org/1805543002
commit 974fa818537a8d00fb3537a836db79e2539a7889
Author: dgozman <dgozman@chromium.org>
R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
NOTRY=true
Review URL: https://codereview.chromium.org/1806643002
Cr-Commit-Position: refs/heads/master@{#381305}
Diffstat (limited to 'extensions/renderer/guest_view')
| -rw-r--r-- | extensions/renderer/guest_view/extensions_guest_view_container.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.cc b/extensions/renderer/guest_view/extensions_guest_view_container.cc index ffa3580..3fa9882 100644 --- a/extensions/renderer/guest_view/extensions_guest_view_container.cc +++ b/extensions/renderer/guest_view/extensions_guest_view_container.cc @@ -5,6 +5,7 @@ #include "extensions/renderer/guest_view/extensions_guest_view_container.h" #include "content/public/renderer/render_frame.h" +#include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h" #include "ui/gfx/geometry/size.h" namespace extensions { @@ -55,8 +56,7 @@ void ExtensionsGuestViewContainer::CallElementResizeCallback( v8::Integer::New(element_resize_isolate_, new_size.height())}; v8::Context::Scope context_scope(context); - v8::MicrotasksScope microtasks( - element_resize_isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks); + blink::WebScopedMicrotaskSuppression suppression; callback->Call(context->Global(), argc, argv); } |