summaryrefslogtreecommitdiffstats
path: root/extensions/renderer/i18n_custom_bindings.cc
diff options
context:
space:
mode:
authordcarney <dcarney@chromium.org>2014-11-20 09:55:07 -0800
committerCommit bot <commit-bot@chromium.org>2014-11-20 17:55:28 +0000
commita261b771b94ccf7bb63f932b0adc8b7f2dc2e946 (patch)
treeedbbd3ec900bcc374e8ef30d09ed154d3ab55546 /extensions/renderer/i18n_custom_bindings.cc
parent6730701ccdc091a34271d51dc3ee9d1f5fc7142a (diff)
downloadchromium_src-a261b771b94ccf7bb63f932b0adc8b7f2dc2e946.zip
chromium_src-a261b771b94ccf7bb63f932b0adc8b7f2dc2e946.tar.gz
chromium_src-a261b771b94ccf7bb63f932b0adc8b7f2dc2e946.tar.bz2
remove some calls to to-be-deprecated v8::Value::To* functions
TBR=eroman@chromium.org, kalman@chromium.org, jamesr@chromium.org BUG= Review URL: https://codereview.chromium.org/744723002 Cr-Commit-Position: refs/heads/master@{#305034}
Diffstat (limited to 'extensions/renderer/i18n_custom_bindings.cc')
-rw-r--r--extensions/renderer/i18n_custom_bindings.cc9
1 files changed, 4 insertions, 5 deletions
diff --git a/extensions/renderer/i18n_custom_bindings.cc b/extensions/renderer/i18n_custom_bindings.cc
index 9e99e13..7626270 100644
--- a/extensions/renderer/i18n_custom_bindings.cc
+++ b/extensions/renderer/i18n_custom_bindings.cc
@@ -34,7 +34,7 @@ void I18NCustomBindings::GetL10nMessage(
if (args[2]->IsNull() || !args[2]->IsString()) {
return;
} else {
- extension_id = *v8::String::Utf8Value(args[2]->ToString());
+ extension_id = *v8::String::Utf8Value(args[2]);
if (extension_id.empty())
return;
}
@@ -73,13 +73,12 @@ void I18NCustomBindings::GetL10nMessage(
if (count > 9)
return;
for (uint32_t i = 0; i < count; ++i) {
- substitutions.push_back(
- *v8::String::Utf8Value(
- placeholders->Get(v8::Integer::New(isolate, i))->ToString()));
+ substitutions.push_back(*v8::String::Utf8Value(placeholders->Get(
+ v8::Integer::New(isolate, i))));
}
} else if (args[1]->IsString()) {
// chrome.i18n.getMessage("message_name", "one param");
- substitutions.push_back(*v8::String::Utf8Value(args[1]->ToString()));
+ substitutions.push_back(*v8::String::Utf8Value(args[1]));
}
args.GetReturnValue().Set(v8::String::NewFromUtf8(