diff options
| author | kalman <kalman@chromium.org> | 2015-08-11 12:12:07 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-11 19:12:53 +0000 |
| commit | 33076cbe96e8eb8c50541e40f5266955c3db667f (patch) | |
| tree | ad57c0c453ad8791355b9c4d96866d58f8c88fea /extensions/renderer/messaging_bindings.cc | |
| parent | 82e03160f0ab87057393935c795701027cb2203c (diff) | |
| download | chromium_src-33076cbe96e8eb8c50541e40f5266955c3db667f.zip chromium_src-33076cbe96e8eb8c50541e40f5266955c3db667f.tar.gz chromium_src-33076cbe96e8eb8c50541e40f5266955c3db667f.tar.bz2 | |
Revert "Convert extensions::SafeBuiltins from a v8::Extension to a NativeHandler."
This reverts commit 68c06a78f74212907faafd985b0bdee67a6d4120.
It caused an iframe performance regression. I plan on re-landing this
after doing some profiling to figure out what exactly the problem is.
TBR=rdevlin.cronin@chromium.org, jochen@chromium.org
BUG=517509, 383974
Review URL: https://codereview.chromium.org/1281793003
Cr-Commit-Position: refs/heads/master@{#342858}
Diffstat (limited to 'extensions/renderer/messaging_bindings.cc')
| -rw-r--r-- | extensions/renderer/messaging_bindings.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/extensions/renderer/messaging_bindings.cc b/extensions/renderer/messaging_bindings.cc index adb6a98..1e0f6e2 100644 --- a/extensions/renderer/messaging_bindings.cc +++ b/extensions/renderer/messaging_bindings.cc @@ -55,7 +55,7 @@ namespace extensions { using v8_helpers::ToV8String; using v8_helpers::ToV8StringUnsafe; -using v8_helpers::IsEmptyOrUndefined; +using v8_helpers::IsEmptyOrUndefied; namespace { @@ -365,7 +365,7 @@ void DispatchOnConnectToScriptContext( script_context->module_system()->CallModuleMethod( "messaging", "dispatchOnConnect", arraysize(arguments), arguments); - if (!IsEmptyOrUndefined(retval)) { + if (!IsEmptyOrUndefied(retval)) { CHECK(retval->IsBoolean()); *port_created |= retval.As<v8::Boolean>()->Value(); } else { @@ -388,7 +388,7 @@ void DeliverMessageToScriptContext(const Message& message, 1, &port_id_handle); // Could be empty/undefined if an exception was thrown. // TODO(kalman): Should this be built into CallModuleMethod? - if (IsEmptyOrUndefined(has_port)) + if (IsEmptyOrUndefied(has_port)) return; CHECK(has_port->IsBoolean()); if (!has_port.As<v8::Boolean>()->Value()) |