diff options
| author | dcheng <dcheng@chromium.org> | 2015-10-02 20:34:22 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-03 03:35:05 +0000 |
| commit | 4dcf62a421fce8a8bd715d5dd6ff9d8f52557eae (patch) | |
| tree | 771a2f48e78aadfb700d159ab8902cb9112c7e17 /extensions/renderer/mojo | |
| parent | 98ebd843dd1c995dde895340c53ceca2e59c9a58 (diff) | |
| download | chromium_src-4dcf62a421fce8a8bd715d5dd6ff9d8f52557eae.zip chromium_src-4dcf62a421fce8a8bd715d5dd6ff9d8f52557eae.tar.gz chromium_src-4dcf62a421fce8a8bd715d5dd6ff9d8f52557eae.tar.bz2 | |
Remove stash_client.js dependency on unload_event.js
unload_event is problematic because it runs JS at inopportune times, in the
main world. This allows arbitrary web content to run JS at a time when
certain invariants in Blink may not hold true.
Unfortunately, the mojo version of the serial API depends on stash_client's
current implementation. Fortunately, it's not actually used in release yet.
BUG=537660
Review URL: https://codereview.chromium.org/1381563007
Cr-Commit-Position: refs/heads/master@{#352231}
Diffstat (limited to 'extensions/renderer/mojo')
| -rw-r--r-- | extensions/renderer/mojo/stash_client_unittest.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/extensions/renderer/mojo/stash_client_unittest.cc b/extensions/renderer/mojo/stash_client_unittest.cc index ec3dc3f..f8076cd 100644 --- a/extensions/renderer/mojo/stash_client_unittest.cc +++ b/extensions/renderer/mojo/stash_client_unittest.cc @@ -39,7 +39,6 @@ class StashClientTest : public ApiTestBase { // Test that stashing and restoring work correctly. TEST_F(StashClientTest, StashAndRestore) { ASSERT_NO_FATAL_FAILURE(RunTest("stash_client_unittest.js", "testStash")); - env()->context()->DispatchOnUnloadEvent(); scoped_ptr<ModuleSystemTestEnvironment> restore_test_env(CreateEnvironment()); ApiTestEnvironment restore_environment(restore_test_env.get()); PrepareEnvironment(&restore_environment); |