summaryrefslogtreecommitdiffstats
path: root/extensions/renderer/v8_helpers.h
diff options
context:
space:
mode:
authorkalman <kalman@chromium.org>2015-08-11 12:12:07 -0700
committerCommit bot <commit-bot@chromium.org>2015-08-11 19:12:53 +0000
commit33076cbe96e8eb8c50541e40f5266955c3db667f (patch)
treead57c0c453ad8791355b9c4d96866d58f8c88fea /extensions/renderer/v8_helpers.h
parent82e03160f0ab87057393935c795701027cb2203c (diff)
downloadchromium_src-33076cbe96e8eb8c50541e40f5266955c3db667f.zip
chromium_src-33076cbe96e8eb8c50541e40f5266955c3db667f.tar.gz
chromium_src-33076cbe96e8eb8c50541e40f5266955c3db667f.tar.bz2
Revert "Convert extensions::SafeBuiltins from a v8::Extension to a NativeHandler."
This reverts commit 68c06a78f74212907faafd985b0bdee67a6d4120. It caused an iframe performance regression. I plan on re-landing this after doing some profiling to figure out what exactly the problem is. TBR=rdevlin.cronin@chromium.org, jochen@chromium.org BUG=517509, 383974 Review URL: https://codereview.chromium.org/1281793003 Cr-Commit-Position: refs/heads/master@{#342858}
Diffstat (limited to 'extensions/renderer/v8_helpers.h')
-rw-r--r--extensions/renderer/v8_helpers.h20
1 files changed, 1 insertions, 19 deletions
diff --git a/extensions/renderer/v8_helpers.h b/extensions/renderer/v8_helpers.h
index e9ac61c..2bfeee8 100644
--- a/extensions/renderer/v8_helpers.h
+++ b/extensions/renderer/v8_helpers.h
@@ -52,7 +52,7 @@ inline bool IsTrue(v8::Maybe<bool> maybe) {
}
// Returns true if |value| is empty or undefined.
-inline bool IsEmptyOrUndefined(v8::Local<v8::Value> value) {
+inline bool IsEmptyOrUndefied(v8::Local<v8::Value> value) {
return value.IsEmpty() || value->IsUndefined();
}
@@ -119,24 +119,6 @@ inline v8::Local<v8::Value> GetPropertyUnsafe(
.ToLocalChecked();
}
-// DeletePropertyUnsafe() family wraps v8::Object::Delete(). They crash when an
-// exception is thrown.
-inline bool DeletePropertyUnsafe(v8::Local<v8::Context> context,
- v8::Local<v8::Object> object,
- v8::Local<v8::Value> key) {
- return object->Delete(context, key).FromJust();
-}
-
-inline bool DeletePropertyUnsafe(
- v8::Local<v8::Context> context,
- v8::Local<v8::Object> object,
- const char* key,
- v8::NewStringType string_type = v8::NewStringType::kNormal) {
- return object->Delete(context, ToV8StringUnsafe(context->GetIsolate(), key,
- string_type))
- .FromJust();
-}
-
// Wraps v8::Function::Call(). Returns true on success.
inline bool CallFunction(v8::Local<v8::Context> context,
v8::Local<v8::Function> function,