diff options
| author | rdevlin.cronin <rdevlin.cronin@chromium.org> | 2016-03-04 10:19:09 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-04 18:21:30 +0000 |
| commit | 163beed3b15b1497b3014cdd491ecb89e375ed66 (patch) | |
| tree | e585c233d4ce12cd00a8378765307c20e147ee58 /extensions/renderer | |
| parent | a23c896572b0417198dbade0f885e226d0e1b32e (diff) | |
| download | chromium_src-163beed3b15b1497b3014cdd491ecb89e375ed66.zip chromium_src-163beed3b15b1497b3014cdd491ecb89e375ed66.tar.gz chromium_src-163beed3b15b1497b3014cdd491ecb89e375ed66.tar.bz2 | |
[Extensions] Use more private properties in our bindings
BUG=591164
Review URL: https://codereview.chromium.org/1756993002
Cr-Commit-Position: refs/heads/master@{#379315}
Diffstat (limited to 'extensions/renderer')
| -rw-r--r-- | extensions/renderer/module_system.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/extensions/renderer/module_system.cc b/extensions/renderer/module_system.cc index f027413..4ca689a 100644 --- a/extensions/renderer/module_system.cc +++ b/extensions/renderer/module_system.cc @@ -399,7 +399,7 @@ void ModuleSystem::LazyFieldGetterInner( v8::Local<v8::External>::Cast(module_system_value)->Value()); v8::Local<v8::Value> v8_module_name; - if (!GetProperty(context, parameters, kModuleName, &v8_module_name)) { + if (!GetPrivateProperty(context, parameters, kModuleName, &v8_module_name)) { Warn(isolate, "Cannot find module."); return; } @@ -419,7 +419,7 @@ void ModuleSystem::LazyFieldGetterInner( v8::Local<v8::Object> module = v8::Local<v8::Object>::Cast(module_value); v8::Local<v8::Value> field_value; - if (!GetProperty(context, parameters, kModuleField, &field_value)) { + if (!GetPrivateProperty(context, parameters, kModuleField, &field_value)) { module_system->HandleException(try_catch); return; } @@ -479,9 +479,9 @@ void ModuleSystem::SetLazyField(v8::Local<v8::Object> object, v8::HandleScope handle_scope(GetIsolate()); v8::Local<v8::Object> parameters = v8::Object::New(GetIsolate()); v8::Local<v8::Context> context = context_->v8_context(); - SetProperty(context, parameters, kModuleName, + SetPrivateProperty(context, parameters, kModuleName, ToV8StringUnsafe(GetIsolate(), module_name.c_str())); - SetProperty(context, parameters, kModuleField, + SetPrivateProperty(context, parameters, kModuleField, ToV8StringUnsafe(GetIsolate(), module_field.c_str())); auto maybe = object->SetAccessor( context, ToV8StringUnsafe(GetIsolate(), field.c_str()), getter, NULL, |