diff options
| author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-31 12:44:06 +0000 |
|---|---|---|
| committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-31 12:44:06 +0000 |
| commit | adf5a10eeb5dc230f27d3b1344f2111bdfcd97d6 (patch) | |
| tree | 8ba5fbfcb3ddaa54355fa3b03cbdcadcbc6d875d /extensions/shell/DEPS | |
| parent | 248ee9be3db637800a1bf7b13817df43f904248b (diff) | |
| download | chromium_src-adf5a10eeb5dc230f27d3b1344f2111bdfcd97d6.zip chromium_src-adf5a10eeb5dc230f27d3b1344f2111bdfcd97d6.tar.gz chromium_src-adf5a10eeb5dc230f27d3b1344f2111bdfcd97d6.tar.bz2 | |
Move extension notifications to extensions/browser/notification_types.h
As part of the extensions module refactor we temporarily allowed the use
of chrome_notification_types.h in src/extensions. However, this allowed
code moving into src/extensions to listen to notifications from Chrome,
which was a layering violation.
This CL moves all the extensions notifications into their own header and
cleans up DEPS to disallow the exception.
BUG=392622
TEST=compiles, unit_tests, browser_tests, extensions_unittests
TBR=miket@chromium.org for apps/
Review URL: https://codereview.chromium.org/425303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286770 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions/shell/DEPS')
| -rw-r--r-- | extensions/shell/DEPS | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/extensions/shell/DEPS b/extensions/shell/DEPS index ffa7287..83649ba 100644 --- a/extensions/shell/DEPS +++ b/extensions/shell/DEPS @@ -1,6 +1,7 @@ include_rules = [ # The apps module has dependencies on chrome. "-apps", + # Individual subdirectories should have their own DEPS that include # their allowed directories. "-extensions/shell", @@ -17,7 +18,4 @@ include_rules = [ "+grit/extensions_resources.h", # Real DEPS go in subdirectories, for example extensions/shell/browser/DEPS. - # Temporary exceptions for app_shell bring-up go here. - # TODO(jamescook): Remove these. http://crbug.com/305404 - "!chrome/browser/chrome_notification_types.h", ] |