diff options
| author | brettw <brettw@chromium.org> | 2014-11-05 22:39:59 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-11-06 06:40:21 +0000 |
| commit | ded26327ea414269d382d06cb093c5625532f616 (patch) | |
| tree | e284e5bbd76abb8a5eb5e07ec8de7be8fe0a6dbb /extensions/shell/app_shell.gyp | |
| parent | 23da376821cac90f9940fe6e3a78eb45250eabca (diff) | |
| download | chromium_src-ded26327ea414269d382d06cb093c5625532f616.zip chromium_src-ded26327ea414269d382d06cb093c5625532f616.tar.gz chromium_src-ded26327ea414269d382d06cb093c5625532f616.tar.bz2 | |
Improve extensions version generation in GN
An error in the invocation of the exec_script call made GN re-run every time you compiled. The reason is that the VERSION file referenced in the deps of the script invocation had the wrong path. Since the file didn't exist, Ninja would always run the build step.
Forking scripts to run a GN-time is very unfortunate and slows everything down. This should only be done in extreme circumstances. There is already a template to do the version scripts at build time, we just need to move the definition of VERSION_FULL from the build file to the .in file.
Review URL: https://codereview.chromium.org/704903002
Cr-Commit-Position: refs/heads/master@{#302972}
Diffstat (limited to 'extensions/shell/app_shell.gyp')
| -rw-r--r-- | extensions/shell/app_shell.gyp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/extensions/shell/app_shell.gyp b/extensions/shell/app_shell.gyp index 88fc22c..d709e3b 100644 --- a/extensions/shell/app_shell.gyp +++ b/extensions/shell/app_shell.gyp @@ -295,8 +295,8 @@ 'action': [ 'python', '<(version_py_path)', - '-e', 'VERSION_FULL="<(version_full)"', '-f', '<(lastchange_path)', + '-f', '<(version_path)', 'common/version.h.in', '<@(_outputs)', ], |