Record when we suppress internal Extension code JavaScript crashes.

Up until recently the behavior has been to crash on canary and dev channels,
pick those up as regressions as per usual (e.g. we get a nice stack trace),
then not crash in beta or stable.

Recently those crashes have picked up, and while I work on a fix for that,
r327369 disabled all crashes, suppressing all crashes. This patch records all
suppressed crashes, something we perhaps should have been doing for a while.

BUG=471599
R=rdevlin.cronin@chromium.org, isherman@chromium.org

Review URL: https://codereview.chromium.org/1114733002

Cr-Commit-Position: refs/heads/master@{#327624}

2 files changed, 4 insertions, 0 deletions

diff --git a/extensions/shell/common/shell_extensions_client.cc b/extensions/shell/common/shell_extensions_client.cc
index c3d07ea..a26c95c 100644
--- a/extensions/shell/common/shell_extensions_client.cc
+++ b/extensions/shell/common/shell_extensions_client.cc
@@ -219,6 +219,9 @@ bool ShellExtensionsClient::ShouldSuppressFatalErrors() const {
   return true;
 }
 
+void ShellExtensionsClient::RecordDidSuppressFatalError() {
+}
+
 std::string ShellExtensionsClient::GetWebstoreBaseURL() const {
   return extension_urls::kChromeWebstoreBaseURL;
 }
diff --git a/extensions/shell/common/shell_extensions_client.h b/extensions/shell/common/shell_extensions_client.h
index 0e8e519..b901040 100644
--- a/extensions/shell/common/shell_extensions_client.h
+++ b/extensions/shell/common/shell_extensions_client.h
@@ -44,6 +44,7 @@ class ShellExtensionsClient : public ExtensionsClient {
   base::StringPiece GetAPISchema(const std::string& name) const override;
   void RegisterAPISchemaResources(ExtensionAPI* api) const override;
   bool ShouldSuppressFatalErrors() const override;
+  void RecordDidSuppressFatalError() override;
   std::string GetWebstoreBaseURL() const override;
   std::string GetWebstoreUpdateURL() const override;
   bool IsBlacklistUpdateURL(const GURL& url) const override;