Provide default implementation of ExtensionsClient::GetBrowserImagePaths

Right now ChromeExtensionsClient has the only real implementation of
this function, and it returns the icons for:

1) the extension itself (the top-level icons key in the manifest)
2) page/browser actions
3) theme images

This patch moves to having a default implementation in ExtensionsClient
of GetBrowserImagePaths which returns the paths for (1), leaving
(2) and (3) speficic to ChromeExtensionsClient.

We need to do this to enable the Unpacker class to move from chrome/ to
extensions/, because the unpacker does some validation checks on the
paths returned by GetBrowserImagePaths and has tests for that
validation we want to move out of chrome/ also.

BUG=447014

Review URL: https://codereview.chromium.org/840813005

Cr-Commit-Position: refs/heads/master@{#310537}

2 files changed, 0 insertions, 7 deletions

diff --git a/extensions/shell/common/shell_extensions_client.cc b/extensions/shell/common/shell_extensions_client.cc
index d20a608cd..611ff99 100644
--- a/extensions/shell/common/shell_extensions_client.cc
+++ b/extensions/shell/common/shell_extensions_client.cc
@@ -222,9 +222,4 @@ bool ShellExtensionsClient::IsBlacklistUpdateURL(const GURL& url) const {
   return true;
 }
 
-std::set<base::FilePath> ShellExtensionsClient::GetBrowserImagePaths(
-    const Extension* extension) {
-  return std::set<base::FilePath>();
-}
-
 }  // namespace extensions
diff --git a/extensions/shell/common/shell_extensions_client.h b/extensions/shell/common/shell_extensions_client.h
index 3e5e9bb..0e8e519 100644
--- a/extensions/shell/common/shell_extensions_client.h
+++ b/extensions/shell/common/shell_extensions_client.h
@@ -47,8 +47,6 @@ class ShellExtensionsClient : public ExtensionsClient {
   std::string GetWebstoreBaseURL() const override;
   std::string GetWebstoreUpdateURL() const override;
   bool IsBlacklistUpdateURL(const GURL& url) const override;
-  std::set<base::FilePath> GetBrowserImagePaths(
-      const Extension* extension) override;
 
  private:
   const ExtensionsAPIPermissions extensions_api_permissions_;