summaryrefslogtreecommitdiffstats
path: root/extensions/shell
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-12-28 12:31:56 -0800
committerCommit bot <commit-bot@chromium.org>2014-12-28 20:32:43 +0000
commitafa7602b2e8b0f3640ab681b8132a970bd133933 (patch)
treebe7be10435fffc7bdcf49466769151c56612cc95 /extensions/shell
parentf13c491db505994d71f7c2c4e11b93f726e9933a (diff)
downloadchromium_src-afa7602b2e8b0f3640ab681b8132a970bd133933.zip
chromium_src-afa7602b2e8b0f3640ab681b8132a970bd133933.tar.gz
chromium_src-afa7602b2e8b0f3640ab681b8132a970bd133933.tar.bz2
Standardize usage of virtual/override/final specifiers in extensions/.
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 Review URL: https://codereview.chromium.org/815503004 Cr-Commit-Position: refs/heads/master@{#309690}
Diffstat (limited to 'extensions/shell')
-rw-r--r--extensions/shell/browser/shell_oauth2_token_service_unittest.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/extensions/shell/browser/shell_oauth2_token_service_unittest.cc b/extensions/shell/browser/shell_oauth2_token_service_unittest.cc
index 71e9c3a..8b9dc72 100644
--- a/extensions/shell/browser/shell_oauth2_token_service_unittest.cc
+++ b/extensions/shell/browser/shell_oauth2_token_service_unittest.cc
@@ -12,7 +12,7 @@ namespace extensions {
class ShellOAuth2TokenServiceTest : public ExtensionsTest {
public:
ShellOAuth2TokenServiceTest() {}
- virtual ~ShellOAuth2TokenServiceTest() {}
+ ~ShellOAuth2TokenServiceTest() override {}
private:
content::TestBrowserThreadBundle thread_bundle_;