diff options
| author | courage <courage@chromium.org> | 2015-07-22 17:51:06 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-23 00:52:01 +0000 |
| commit | dff351a5527dd5cf81b4740e4caf63e84a3e9d2f (patch) | |
| tree | 942cd8da888848275153f8110d1146f71a171605 /extensions/shell | |
| parent | 6a85e9f34f82eac95e44006640e75c3a08e6e310 (diff) | |
| download | chromium_src-dff351a5527dd5cf81b4740e4caf63e84a3e9d2f.zip chromium_src-dff351a5527dd5cf81b4740e4caf63e84a3e9d2f.tar.gz chromium_src-dff351a5527dd5cf81b4740e4caf63e84a3e9d2f.tar.bz2 | |
Revert of Add missing dependencies. (patchset #7 id:120001 of https://codereview.chromium.org/1242323004/)
Reason for revert:
It looks to me like this broke the iOS_Device builder starting at https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/14003, despite the green trybots.
=== BUILD TARGET osmesa OF PROJECT mesa WITH CONFIGURATION Release ===
Check dependencies
CodeSign error: code signing is required for product type 'Dynamic Library' in SDK 'iOS 8.3'
** BUILD FAILED **
The following build commands failed:
Check dependencies
(1 failure)
Original issue's description:
> Add missing runtime dependencies to *_run targets.
>
> A follow up CL removes dynamic libraries that would be fetched automatically via
> implicit dependencies. The target hierarchy needs to be there in the first
> place for this to work.
>
> R=jam@chromium.org
> BUG=98637
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/d7b8df80cd5ce2a882bbf35482dc21cee34934f9
> Cr-Commit-Position: refs/heads/master@{#339994}
TBR=jam@chromium.org,danakj@chromium.org,marcheu@chromium.org,maruel@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=98637
Review URL: https://codereview.chromium.org/1247533003
Cr-Commit-Position: refs/heads/master@{#340015}
Diffstat (limited to 'extensions/shell')
| -rw-r--r-- | extensions/shell/app_shell.gyp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/extensions/shell/app_shell.gyp b/extensions/shell/app_shell.gyp index f2e661b..4a41b30 100644 --- a/extensions/shell/app_shell.gyp +++ b/extensions/shell/app_shell.gyp @@ -215,8 +215,6 @@ '<(DEPTH)/extensions/extensions.gyp:extensions_shell_and_test_pak', '<(DEPTH)/extensions/extensions.gyp:extensions_test_support', '<(DEPTH)/testing/gtest.gyp:gtest', - # Only needed at runtime. - '../../third_party/mesa/mesa.gyp:osmesa', ], 'sources': [ '<@(app_shell_unittests_sources)', |