diff options
author | alexclarke <alexclarke@chromium.org> | 2015-07-14 02:50:18 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-07-14 09:50:56 +0000 |
commit | a0743be4faeba12784322efb70387bf708308bf6 (patch) | |
tree | 51e799efb8a78b4ba02eaa49d5b0c67adb42a8e1 /extensions/test | |
parent | 7c0e19558a837263c1c447a237b699f1fd17c7ee (diff) | |
download | chromium_src-a0743be4faeba12784322efb70387bf708308bf6.zip chromium_src-a0743be4faeba12784322efb70387bf708308bf6.tar.gz chromium_src-a0743be4faeba12784322efb70387bf708308bf6.tar.bz2 |
Revert of Refactored TestExpectations out of Telemetry and into content/test/gpu. (patchset #5 id:70001 of https://codereview.chromium.org/1224233005/)
Reason for revert:
I believe this patch broke the blink_perf.canvas perf test on Linux, Mac and Windows:
http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29/builds/8101/steps/blink_perf.canvas/logs/stdio
http://build.chromium.org/p/chromium.perf/builders/Mac%2010.8%20Perf%20%284%29/builds/5636/steps/blink_perf.canvas/logs/stdio
http://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf%20%284%29/builds/815/steps/blink_perf.canvas/logs/stdio
Original issue's description:
> Refactored TestExpectations out of Telemetry and into content/test/gpu.
>
> The GPU tests are the primary user of Telemetry's TestExpectations,
> and it turns out they can be implemented entirely in the code using
> Telemetry, rather than Telemetry itself. For this reason, move them
> into content/test/gpu.
>
> Refactored the GPU tests to all derive from a common set of base
> classes implementing support for test expectations. Verified that
> skipping tests, expected failures, and flaky test handling all work.
> More tests of test expectations are needed, and will be added in later
> CLs; this one is too large already, but can't be broken up further.
>
> Fixed up two WebGL perf tests that were relying on test expectations
> to skip the pages on specific GPUs, and added a hook to Telemetry's
> browser_info to enable this.
>
> This CL loses one valuable test,
> testHandlingOfCrashedTabWithExpectedFailure, from
> page_run_end_to_end_unittest.py. It will be reintroduced in a later CL.
>
> A subsequent CL will redesign TestExpectations. This CL is intended to
> be a refactoring with no behavioral changes.
>
> Ran telemetry_unittests, telemetry_gpu_unittests,
> telemetry_perf_unittests, and all GPU tests locally to verify.
>
> BUG=495870
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect
>
> Committed: https://crrev.com/5b3151cd707dee82b947ae096b12967e3c4a7c26
> Cr-Commit-Position: refs/heads/master@{#338623}
TBR=aiolos@chromium.org,dtu@chromium.org,nednguyen@google.com,bajones@chromium.org,zmo@chromium.org,zhenw@chromium.org,kbr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=495870
Review URL: https://codereview.chromium.org/1238653002
Cr-Commit-Position: refs/heads/master@{#338662}
Diffstat (limited to 'extensions/test')
0 files changed, 0 insertions, 0 deletions