diff options
| author | brettw <brettw@chromium.org> | 2015-07-16 10:49:29 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-16 17:50:12 +0000 |
| commit | a7ff1b291cd328e9584779a4bb9101fa9a3c01ad (patch) | |
| tree | d010374be1ca156ea26405ae7b0aa85e48bb4bba /extensions/utility | |
| parent | 7befa9cf85342a0409502ed2c05d7610afec7844 (diff) | |
| download | chromium_src-a7ff1b291cd328e9584779a4bb9101fa9a3c01ad.zip chromium_src-a7ff1b291cd328e9584779a4bb9101fa9a3c01ad.tar.gz chromium_src-a7ff1b291cd328e9584779a4bb9101fa9a3c01ad.tar.bz2 | |
Remove some legacy versions of StartsWith and EndsWith.
This just replaces
true -> base::CompareCase::SENSITIVE
false -> base::CompareCase::INSENSITIVE_ASCII
I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at.
extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable.
BUG=506255
TBR=jam
Reland of http://crrev.com/1239493005
Review URL: https://codereview.chromium.org/1233043003
Cr-Commit-Position: refs/heads/master@{#339071}
Diffstat (limited to 'extensions/utility')
| -rw-r--r-- | extensions/utility/unpacker_unittest.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/extensions/utility/unpacker_unittest.cc b/extensions/utility/unpacker_unittest.cc index bb99aae..82e5a1f7 100644 --- a/extensions/utility/unpacker_unittest.cc +++ b/extensions/utility/unpacker_unittest.cc @@ -171,7 +171,8 @@ TEST_F(UnpackerTest, BadPathError) { EXPECT_FALSE(unpacker_->Run()); EXPECT_TRUE(base::StartsWith(unpacker_->error_message(), - ASCIIToUTF16(kExpected), false)) + ASCIIToUTF16(kExpected), + base::CompareCase::INSENSITIVE_ASCII)) << "Expected prefix: \"" << kExpected << "\", actual error: \"" << unpacker_->error_message() << "\""; } @@ -181,7 +182,8 @@ TEST_F(UnpackerTest, ImageDecodingError) { SetupUnpacker("bad_image.crx"); EXPECT_FALSE(unpacker_->Run()); EXPECT_TRUE(base::StartsWith(unpacker_->error_message(), - ASCIIToUTF16(kExpected), false)) + ASCIIToUTF16(kExpected), + base::CompareCase::INSENSITIVE_ASCII)) << "Expected prefix: \"" << kExpected << "\", actual error: \"" << unpacker_->error_message() << "\""; } |