diff options
| author | limasdf <limasdf@gmail.com> | 2015-11-20 08:54:32 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-20 16:55:35 +0000 |
| commit | 3b5b2d147fe384fea0c07814e23b3fd5bdbb0792 (patch) | |
| tree | 30b5d67b5cb2a8238ef10194b36787d95cde0d3f /extensions | |
| parent | 21c9153893f4a238cb65ec353a80ff9483b1d130 (diff) | |
| download | chromium_src-3b5b2d147fe384fea0c07814e23b3fd5bdbb0792.zip chromium_src-3b5b2d147fe384fea0c07814e23b3fd5bdbb0792.tar.gz chromium_src-3b5b2d147fe384fea0c07814e23b3fd5bdbb0792.tar.bz2 | |
Kill NOTIFICATION_EXTENSION_WILL_BE_INSTALLED_DEPRECATED
Removing code where using it.
- WaitForExtensionInstall() from c/b/e/extension_browsertest.h
which having unclear behavior. (we're not able to expect when starting observing)
- from extension_service.h where notify ..._INSTALLED_DEPRECATED
TEST=browser_tests
BUG=411568
Review URL: https://codereview.chromium.org/1403373020
Cr-Commit-Position: refs/heads/master@{#360840}
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/browser/notification_types.h | 7 | ||||
| -rw-r--r-- | extensions/shell/browser/shell_extension_system.cc | 2 |
2 files changed, 1 insertions, 8 deletions
diff --git a/extensions/browser/notification_types.h b/extensions/browser/notification_types.h index e5ae4ba..b99454c 100644 --- a/extensions/browser/notification_types.h +++ b/extensions/browser/notification_types.h @@ -58,13 +58,6 @@ enum NotificationType { // UpdatedExtensionPermissionsInfo, and the source is a BrowserContext*. NOTIFICATION_EXTENSION_PERMISSIONS_UPDATED, - // Sent immediately before new extensions are installed or existing - // extensions are updated. The details are an InstalledExtensionInfo, and the - // source is a BrowserContext*. - // - // DEPRECATED: Use ExtensionRegistry::AddObserver instead. - NOTIFICATION_EXTENSION_WILL_BE_INSTALLED_DEPRECATED, - // An error occured during extension install. The details are a string with // details about why the install failed. NOTIFICATION_EXTENSION_INSTALL_ERROR, diff --git a/extensions/shell/browser/shell_extension_system.cc b/extensions/shell/browser/shell_extension_system.cc index b6cff6a..e3a75bf 100644 --- a/extensions/shell/browser/shell_extension_system.cc +++ b/extensions/shell/browser/shell_extension_system.cc @@ -56,7 +56,7 @@ const Extension* ShellExtensionSystem::LoadApp(const base::FilePath& app_dir) { // * Call PermissionsUpdater::GrantActivePermissions(). // * Call ExtensionService::SatisfyImports(). // * Call ExtensionPrefs::OnExtensionInstalled(). - // * Send NOTIFICATION_EXTENSION_WILL_BE_INSTALLED_DEPRECATED. + // * Call ExtensionRegistryObserver::OnExtensionWillbeInstalled(). ExtensionRegistry::Get(browser_context_)->AddEnabled(extension.get()); |