diff options
| author | mohammed@chromium.org <mohammed@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-23 22:07:02 +0000 |
|---|---|---|
| committer | mohammed@chromium.org <mohammed@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-23 22:07:02 +0000 |
| commit | 53005c71eddd32fabc44df9285565a641bbe5932 (patch) | |
| tree | ed3c4da98fd57e5458cbef15e3172e1f9698f8e9 /extensions | |
| parent | 182c1aade540a3d33ad39e3d846ac071eb8d2b66 (diff) | |
| download | chromium_src-53005c71eddd32fabc44df9285565a641bbe5932.zip chromium_src-53005c71eddd32fabc44df9285565a641bbe5932.tar.gz chromium_src-53005c71eddd32fabc44df9285565a641bbe5932.tar.bz2 | |
Fixing the consistency with permissions warnings message with respect to "read" and "write".
The "read" and "write" strings are all different among warnings.
So far we have:
Read and write
Read and modify
Read and change
Access and modify
Access and change
To ensure consistency all of them should use "read" and "change" whenever possible. Also according to Helen's findings, users don't know the exact meaning of the word "access".
BUG=386224
R=jww,meacer,felt
Review URL: https://codereview.chromium.org/348483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279191 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/common/permissions/permissions_data_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/extensions/common/permissions/permissions_data_unittest.cc b/extensions/common/permissions/permissions_data_unittest.cc index dc3aa86..e86b8cd 100644 --- a/extensions/common/permissions/permissions_data_unittest.cc +++ b/extensions/common/permissions/permissions_data_unittest.cc @@ -251,9 +251,9 @@ TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyAPIPermissions) { ASSERT_EQ(5u, warnings.size()); EXPECT_EQ("Read and modify your data on api.flickr.com", UTF16ToUTF8(warnings[0])); - EXPECT_EQ("Read and modify your bookmarks", UTF16ToUTF8(warnings[1])); + EXPECT_EQ("Read and change your bookmarks", UTF16ToUTF8(warnings[1])); EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[2])); - EXPECT_EQ("Read and modify your browsing history", UTF16ToUTF8(warnings[3])); + EXPECT_EQ("Read and change your browsing history", UTF16ToUTF8(warnings[3])); EXPECT_EQ("Manage your apps, extensions, and themes", UTF16ToUTF8(warnings[4])); } @@ -308,7 +308,7 @@ TEST(ExtensionPermissionsTest, GetPermissionMessages_Plugins) { #else ASSERT_EQ(1u, warnings.size()); EXPECT_EQ( - "Read and modify all your data on your computer and the websites you " + "Read and change all your data on your computer and the websites you " "visit", UTF16ToUTF8(warnings[0])); #endif |