diff options
| author | sammc <sammc@chromium.org> | 2016-03-13 23:04:42 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-14 06:06:49 +0000 |
| commit | cabf453e023d5c636384cf673e2f418aebac3a64 (patch) | |
| tree | ac290b2a66c1ef1a1257271d3c2455fbf1626652 /extensions | |
| parent | 4ed4249af7e3bfe75700dc534a4b8c718735a8d7 (diff) | |
| download | chromium_src-cabf453e023d5c636384cf673e2f418aebac3a64.zip chromium_src-cabf453e023d5c636384cf673e2f418aebac3a64.tar.gz chromium_src-cabf453e023d5c636384cf673e2f418aebac3a64.tar.bz2 | |
Remove a debugging CHECK from MimeHandlerViewGuest.
With https://crrev.com/366034, the guest will be destroyed if it's
detached so DocumentOnLoadCompletedInMainFrame() will only be called in
a state where embedder_web_contents() is valid.
BUG=569990
Review URL: https://codereview.chromium.org/1798663003
Cr-Commit-Position: refs/heads/master@{#380932}
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc index d704b9f..27297f3 100644 --- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc +++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc @@ -227,18 +227,12 @@ bool MimeHandlerViewGuest::SaveFrame(const GURL& url, } void MimeHandlerViewGuest::DocumentOnLoadCompletedInMainFrame() { - // Assume the embedder WebContents is valid here. Change this to a DCHECK - // after verifying https://crbug.com/569990. - CHECK(owner_web_contents()); - - // Although we should always be attached before loading is complete, the - // MimeHandlerViewGuest may become detached in some cases so we still need - // to check whether we're attached here. - if (attached()) { - embedder_web_contents()->Send( - new ExtensionsGuestViewMsg_MimeHandlerViewGuestOnLoadCompleted( - element_instance_id())); - } + // Assume the embedder WebContents is valid here. + DCHECK(embedder_web_contents()); + + embedder_web_contents()->Send( + new ExtensionsGuestViewMsg_MimeHandlerViewGuestOnLoadCompleted( + element_instance_id())); } base::WeakPtr<StreamContainer> MimeHandlerViewGuest::GetStream() const { |