diff options
| author | rockot <rockot@chromium.org> | 2014-11-04 11:09:25 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-11-04 19:09:47 +0000 |
| commit | e2284fd9e2d42285a925d60aea5b8d0b769b2381 (patch) | |
| tree | b90e59dd3138ea020149a029d7d94537453b9768 /extensions | |
| parent | 2eb362d23158c4897a9346edae4e630c6c9f2702 (diff) | |
| download | chromium_src-e2284fd9e2d42285a925d60aea5b8d0b769b2381.zip chromium_src-e2284fd9e2d42285a925d60aea5b8d0b769b2381.tar.gz chromium_src-e2284fd9e2d42285a925d60aea5b8d0b769b2381.tar.bz2 | |
Refine //extensions DEPS on //ui
This patch makes more explicit the set of dependencies
allowed from //extensions onto //ui.
//extensions was allowing dependencies on all of //ui
by default. This is unfortunate for people who want to
introduce new code into //extensions only to be shot
down because they depend on pieces of ui that aren't
allowed.
BUG=None
Review URL: https://codereview.chromium.org/702513002
Cr-Commit-Position: refs/heads/master@{#302637}
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/DEPS | 11 | ||||
| -rw-r--r-- | extensions/components/native_app_window/DEPS | 3 | ||||
| -rw-r--r-- | extensions/shell/browser/DEPS | 8 | ||||
| -rw-r--r-- | extensions/test/DEPS | 1 |
4 files changed, 20 insertions, 3 deletions
diff --git a/extensions/DEPS b/extensions/DEPS index d2bbec8..21a0ba6 100644 --- a/extensions/DEPS +++ b/extensions/DEPS @@ -13,7 +13,16 @@ include_rules = [ "+grit/extensions_resources.h", "+mojo/public", "+testing", - "+ui", + + # Minimal UI dependencies. There are two good rules for UI dependencies here: + # + # 1) UI components should only be added as they are needed, and + # 2) if //content doesn't allow it, //extensions probably won't allow it. + # (see for example ui/views) + "-ui", + "+ui/base", + "+ui/gfx", + "+ui/events", # NOTE: Please do not add includes without talking to the app shell team; # see OWNERS for this directory. diff --git a/extensions/components/native_app_window/DEPS b/extensions/components/native_app_window/DEPS index aa37418..a3755f9 100644 --- a/extensions/components/native_app_window/DEPS +++ b/extensions/components/native_app_window/DEPS @@ -1,4 +1,7 @@ include_rules = [ "+content/public/browser", "+third_party/skia/include/core/SkRegion.h", + + "+ui/aura", + "+ui/views", ] diff --git a/extensions/shell/browser/DEPS b/extensions/shell/browser/DEPS index b692a0a..3cb86f2 100644 --- a/extensions/shell/browser/DEPS +++ b/extensions/shell/browser/DEPS @@ -28,8 +28,12 @@ include_rules = [ "+storage/browser/quota", "+sync/api", - # Disallow views to keep the binary size down. - "-ui/views", + # Additional UI dependencies for app_shell. Note that no particular UI toolkit + # is supported; only Aura and some necessary bits to set up display surfaces. + "+ui/aura", + "+ui/chromeos", + "+ui/display", + "+ui/wm", "+third_party/cros_system_api", diff --git a/extensions/test/DEPS b/extensions/test/DEPS index 925491d..27ef4ea 100644 --- a/extensions/test/DEPS +++ b/extensions/test/DEPS @@ -1,4 +1,5 @@ include_rules = [ "+content/public", "+mojo/edk/embedder", + "+ui/gl", ] |