diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-27 06:08:24 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-27 06:08:24 +0000 |
| commit | 1771610df43ea45158fcb5f2776852f1e5f4e92b (patch) | |
| tree | f32652253b296d125497b25dcc51534e4cbc677a /gin/per_context_data.cc | |
| parent | 2b2e427dcaa14737774a166adf38b68666bfad1e (diff) | |
| download | chromium_src-1771610df43ea45158fcb5f2776852f1e5f4e92b.zip chromium_src-1771610df43ea45158fcb5f2776852f1e5f4e92b.tar.gz chromium_src-1771610df43ea45158fcb5f2776852f1e5f4e92b.tar.bz2 | |
Refactors parts of gin:
. Runner no longer extends ContextHolder. It will still have a
ContextHolder, but not own it. This enables a couple of
things:
. Runner no longer need own a v8::Context.
. Runner can be lazily created after the ContextHolder.
. Runner becomes a (mostly) pure virtual interface. This enables an
implementation to execute through blink rather than v8 directly.
. What was Runner is now DefaultRunner (and
DefaultRunnerDelegate). I'm not a fan of these names, if you have
better ideas let me know. Maybe DirectRunner?
BUG=none
TEST=none
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/179803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253732 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gin/per_context_data.cc')
| -rw-r--r-- | gin/per_context_data.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gin/per_context_data.cc b/gin/per_context_data.cc index 5183d00..5fedf52 100644 --- a/gin/per_context_data.cc +++ b/gin/per_context_data.cc @@ -40,6 +40,7 @@ void PerContextData::Detach(v8::Handle<v8::Context> context) { } } +// static PerContextData* PerContextData::From(v8::Handle<v8::Context> context) { return static_cast<PerContextData*>( context->GetAlignedPointerFromEmbedderData(kEncodedValueIndex)); |