Refactor IsolateHolder to be able to always create the isolate

Currently, blink creates its own isolates. We want to always use an
IsolateHolder to create the isolates. To be able to do this, I introduce
an Initialize method that setups V8. The new IsolateHolder ctor now
doesn't take any parameters but just creates new isolates according to
the configuration.

All non-blink gin users are cut over to the new API

BUG=none
R=abarth@chromium.org,andrewhayden@chromium.org,eroman@chromium.org

Review URL: https://codereview.chromium.org/553903003

Cr-Commit-Position: refs/heads/master@{#294262}

1 files changed, 4 insertions, 1 deletions

diff --git a/gin/shell_runner_unittest.cc b/gin/shell_runner_unittest.cc
index 95403ec..07ab678 100644
--- a/gin/shell_runner_unittest.cc
+++ b/gin/shell_runner_unittest.cc
@@ -5,6 +5,7 @@
 #include "gin/shell_runner.h"
 
 #include "base/compiler_specific.h"
+#include "gin/array_buffer.h"
 #include "gin/converter.h"
 #include "gin/public/isolate_holder.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ -19,7 +20,9 @@ namespace gin {
 TEST(RunnerTest, Run) {
   std::string source = "this.result = 'PASS';\n";
 
-  gin::IsolateHolder instance(gin::IsolateHolder::kStrictMode);
+  gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
+                                 gin::ArrayBufferAllocator::SharedInstance());
+  gin::IsolateHolder instance;
 
   ShellRunnerDelegate delegate;
   Isolate* isolate = instance.isolate();