summaryrefslogtreecommitdiffstats
path: root/gin/test
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-10-23 12:08:25 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-23 19:09:19 +0000
commit074c039593e8beb054fcc7a2701e753883eaa596 (patch)
tree88c830fd932ec658bc7e98a8e995068c418802d9 /gin/test
parent7eeb2fab96ab2a51e0d9f9a81c6ff4ab5b1aa8c8 (diff)
downloadchromium_src-074c039593e8beb054fcc7a2701e753883eaa596.zip
chromium_src-074c039593e8beb054fcc7a2701e753883eaa596.tar.gz
chromium_src-074c039593e8beb054fcc7a2701e753883eaa596.tar.bz2
Standardize usage of virtual/override/final in gin/
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=abarth@chromium.org Review URL: https://codereview.chromium.org/645853012 Cr-Commit-Position: refs/heads/master@{#300925}
Diffstat (limited to 'gin/test')
-rw-r--r--gin/test/file_runner.h5
1 files changed, 2 insertions, 3 deletions
diff --git a/gin/test/file_runner.h b/gin/test/file_runner.h
index 5082cd5..9f7ab4b 100644
--- a/gin/test/file_runner.h
+++ b/gin/test/file_runner.h
@@ -20,12 +20,11 @@ namespace gin {
class FileRunnerDelegate : public ModuleRunnerDelegate {
public:
FileRunnerDelegate();
- virtual ~FileRunnerDelegate();
+ ~FileRunnerDelegate() override;
private:
// From ModuleRunnerDelegate:
- virtual void UnhandledException(ShellRunner* runner,
- TryCatch& try_catch) override;
+ void UnhandledException(ShellRunner* runner, TryCatch& try_catch) override;
DISALLOW_COPY_AND_ASSIGN(FileRunnerDelegate);
};