diff options
| author | nyquist <nyquist@chromium.org> | 2016-03-08 00:01:50 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-08 08:04:10 +0000 |
| commit | 04f19da143d8d119b781cfa1574c3acc47e4c61c (patch) | |
| tree | 604213642c09c045f2fca164d81835e7ae085eee /gin | |
| parent | b0c601af8b5c132fa30700842501c19ad2c9583b (diff) | |
| download | chromium_src-04f19da143d8d119b781cfa1574c3acc47e4c61c.zip chromium_src-04f19da143d8d119b781cfa1574c3acc47e4c61c.tar.gz chromium_src-04f19da143d8d119b781cfa1574c3acc47e4c61c.tar.bz2 | |
Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #5 id:80001 of https://codereview.chromium.org/1743763004/ )
Reason for revert:
Causes content_unittests to fail on GinJavaBridgeValueConverterTest.TypedArrays for Android on a bunch of testers:
Marshmallow Tablet Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/3117
Marshmallow 64 bit Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/1010
Lollipop Tablet Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/2108
Lollipop Phone Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/3403
Lollipop Low-end Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/2681
git bisect succesfully identified this CL as the culprit:
83013584d091473d3a5fee6a823bc63b223a472c is the first bad commit
See http://crbug.com/592906 for details.
Original issue's description:
> Use v8::MicrotasksScope internally in V8RecursionScope.
>
> If this sticks we can just remove V8RecursionScope and WebScopedMicrotaskSuppression,
> along with other cleanups.
>
> BUG=585949
>
> Committed: https://crrev.com/83013584d091473d3a5fee6a823bc63b223a472c
> Cr-Commit-Position: refs/heads/master@{#379574}
TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=585949
Review URL: https://codereview.chromium.org/1765423004
Cr-Commit-Position: refs/heads/master@{#379781}
Diffstat (limited to 'gin')
| -rw-r--r-- | gin/run_microtasks_observer.cc | 2 | ||||
| -rw-r--r-- | gin/run_microtasks_observer.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/gin/run_microtasks_observer.cc b/gin/run_microtasks_observer.cc index 0ca0078..f453a66 100644 --- a/gin/run_microtasks_observer.cc +++ b/gin/run_microtasks_observer.cc @@ -15,7 +15,7 @@ void RunMicrotasksObserver::WillProcessTask(const base::PendingTask& task) { void RunMicrotasksObserver::DidProcessTask(const base::PendingTask& task) { v8::Isolate::Scope scope(isolate_); - v8::MicrotasksScope::PerformCheckpoint(isolate_); + isolate_->RunMicrotasks(); } } // namespace gin diff --git a/gin/run_microtasks_observer.h b/gin/run_microtasks_observer.h index ca160be..7f1431f 100644 --- a/gin/run_microtasks_observer.h +++ b/gin/run_microtasks_observer.h @@ -12,7 +12,7 @@ namespace gin { // Runs any pending v8 Microtasks each time a task is completed. // TODO(hansmuller); At some point perhaps this can be replaced with -// the (currently experimental) v8::MicrotasksPolicy::kAuto method. +// the (currently experimental) Isolate::SetAutorunMicrotasks() method. class RunMicrotasksObserver : public base::MessageLoop::TaskObserver { public: |