summaryrefslogtreecommitdiffstats
path: root/gin
diff options
context:
space:
mode:
authorjochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-27 15:46:40 +0000
committerjochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-27 15:46:40 +0000
commit9a62a6f866513fe3820bafe48da3745b7e823691 (patch)
tree4247bd9f7b6116b775619923988763fe17afea1e /gin
parentdfcc39c73848d29c8466934c2238159ed6c41412 (diff)
downloadchromium_src-9a62a6f866513fe3820bafe48da3745b7e823691.zip
chromium_src-9a62a6f866513fe3820bafe48da3745b7e823691.tar.gz
chromium_src-9a62a6f866513fe3820bafe48da3745b7e823691.tar.bz2
Remove WrappableTest.ErrorInObjectConstructorProperty
This test was supposed to test that gin can cope with v8 throwing exceptions during object construction, e.g. when we run out of stack space. There is, however, no reliable way to emulate "running out of stack" in a unit test without risking to also crash because of OOM. BUG=none R=dcarney@chromium.org Review URL: https://codereview.chromium.org/337883005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280336 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gin')
-rw-r--r--gin/wrappable_unittest.cc22
1 files changed, 0 insertions, 22 deletions
diff --git a/gin/wrappable_unittest.cc b/gin/wrappable_unittest.cc
index 4916153..9843329 100644
--- a/gin/wrappable_unittest.cc
+++ b/gin/wrappable_unittest.cc
@@ -222,28 +222,6 @@ TEST_F(WrappableTest, WrappableSubclass) {
EXPECT_EQ("Hello, Lily", object->result);
}
-TEST_F(WrappableTest, ErrorInObjectConstructorProperty) {
- v8::Isolate* isolate = instance_->isolate();
- v8::HandleScope handle_scope(isolate);
-
- v8::Handle<v8::String> source = StringToV8(
- isolate,
- "(function() {"
- " Object.defineProperty(Object.prototype, 'constructor', {"
- " get: function() { throw 'Error'; },"
- " set: function() { throw 'Error'; }"
- " });"
- "})();");
- EXPECT_FALSE(source.IsEmpty());
- v8::Handle<v8::Script> script = v8::Script::Compile(source);
- script->Run();
-
- gin::TryCatch try_catch;
- gin::Handle<MyObject> obj = MyObject::Create(isolate);
- EXPECT_TRUE(obj.IsEmpty());
- EXPECT_TRUE(try_catch.HasCaught());
-}
-
TEST_F(WrappableTest, CallAsFunction) {
v8::Isolate* isolate = instance_->isolate();
v8::HandleScope handle_scope(isolate);