diff options
| author | brettw <brettw@chromium.org> | 2015-05-19 15:31:58 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-19 22:31:54 +0000 |
| commit | eadea21096be21b0d74c93f5b1a0ae6a9cc057d7 (patch) | |
| tree | 0238100cb4f234c743630b27ef83839cdc607b03 /gin | |
| parent | 16895a087c44f9b65eba06c09c2e9d69f80eb7d6 (diff) | |
| download | chromium_src-eadea21096be21b0d74c93f5b1a0ae6a9cc057d7.zip chromium_src-eadea21096be21b0d74c93f5b1a0ae6a9cc057d7.tar.gz chromium_src-eadea21096be21b0d74c93f5b1a0ae6a9cc057d7.tar.bz2 | |
Fix missing GN dependencies.
Fixes some cases where a dependency between a target's inputs and outputs exists without an explicit dependency.
json_schema_api.gni was generating wrong names, this was fixed.
mojo_application_package.gni was fixed to generate unique names (just a bug I noticed in passing) and support the testonly flag, which is necessary when I added the correct dependency.
The rest of the cases are just adding deps or making existing deps public so that the ability to depend on the target's outputs is passed to dependents.
BUG=487897
Review URL: https://codereview.chromium.org/1128163007
Cr-Commit-Position: refs/heads/master@{#330636}
Diffstat (limited to 'gin')
| -rw-r--r-- | gin/BUILD.gn | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/gin/BUILD.gn b/gin/BUILD.gn index ab768ff..793ee3d 100644 --- a/gin/BUILD.gn +++ b/gin/BUILD.gn @@ -76,10 +76,8 @@ component("gin") { "//base/third_party/dynamic_annotations", ] if (v8_use_external_startup_data && is_win) { - deps += [ - ":gin_v8_snapshot_fingerprint", - "//crypto:crypto", - ] + public_deps += [ ":gin_v8_snapshot_fingerprint" ] + deps += [ "//crypto:crypto" ] sources += [ "$target_gen_dir/v8_snapshot_fingerprint.cc" ] defines += [ "V8_VERIFY_EXTERNAL_STARTUP_DATA" ] } @@ -108,6 +106,10 @@ if (v8_use_external_startup_data) { outputs = [ output_file, ] + + deps = [ + "//v8", + ] } } |