diff options
author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 08:46:45 +0000 |
---|---|---|
committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 08:46:45 +0000 |
commit | 007b3f812fc9c989fb99d4a668d8bd9c7807ad81 (patch) | |
tree | 43e69dd0f4e4dbbe68afb6319fa18cee07a4be64 /google_apis/gaia/oauth2_mint_token_flow.cc | |
parent | 2bde7e94eb8f402839145e48924391a5c645a554 (diff) | |
download | chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.zip chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.tar.gz chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.tar.bz2 |
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'google_apis/gaia/oauth2_mint_token_flow.cc')
-rw-r--r-- | google_apis/gaia/oauth2_mint_token_flow.cc | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/google_apis/gaia/oauth2_mint_token_flow.cc b/google_apis/gaia/oauth2_mint_token_flow.cc index 42fc4ef..169d187 100644 --- a/google_apis/gaia/oauth2_mint_token_flow.cc +++ b/google_apis/gaia/oauth2_mint_token_flow.cc @@ -89,17 +89,16 @@ OAuth2MintTokenFlow::Parameters::Parameters( OAuth2MintTokenFlow::Parameters::~Parameters() {} -OAuth2MintTokenFlow::OAuth2MintTokenFlow( - URLRequestContextGetter* context, - Delegate* delegate, - const Parameters& parameters) - : OAuth2ApiCallFlow( - context, parameters.login_refresh_token, - "", std::vector<std::string>()), +OAuth2MintTokenFlow::OAuth2MintTokenFlow(URLRequestContextGetter* context, + Delegate* delegate, + const Parameters& parameters) + : OAuth2ApiCallFlow(context, + parameters.login_refresh_token, + std::string(), + std::vector<std::string>()), delegate_(delegate), parameters_(parameters), - ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) { -} + ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {} OAuth2MintTokenFlow::~OAuth2MintTokenFlow() { } |