diff options
| author | ryansturm <ryansturm@chromium.org> | 2016-03-03 15:41:07 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-03 23:43:53 +0000 |
| commit | 4bab0683f19f749d1974944281c07abbc0d814cf (patch) | |
| tree | 0029717741a2fabbdf00022f0ee0588ab5cfa64a /google_apis/gcm/engine | |
| parent | 981e50f65b63f960783c8318c2fbc5ad02dc71b7 (diff) | |
| download | chromium_src-4bab0683f19f749d1974944281c07abbc0d814cf.zip chromium_src-4bab0683f19f749d1974944281c07abbc0d814cf.tar.gz chromium_src-4bab0683f19f749d1974944281c07abbc0d814cf.tar.bz2 | |
Bypass the DataReductionProxy for all POST requests
POST requests are non-dempotent, so clients using the Data Reduction Proxy (DRP) can often end up at an error page due to the fact that if the DRP has any problems connecting to the origin, DRP and the client will not be safely able to determine if the post successfully made it to the server. The impact of this change on data compression should be very limited, and it will improve the client's experience.
BUG=581750
Review URL: https://codereview.chromium.org/1684123004
Cr-Commit-Position: refs/heads/master@{#379137}
Diffstat (limited to 'google_apis/gcm/engine')
| -rw-r--r-- | google_apis/gcm/engine/connection_factory_impl.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/google_apis/gcm/engine/connection_factory_impl.cc b/google_apis/gcm/engine/connection_factory_impl.cc index 43bac40..de25235 100644 --- a/google_apis/gcm/engine/connection_factory_impl.cc +++ b/google_apis/gcm/engine/connection_factory_impl.cc @@ -4,6 +4,8 @@ #include "google_apis/gcm/engine/connection_factory_impl.h" +#include <string> + #include "base/location.h" #include "base/metrics/histogram.h" #include "base/metrics/sparse_histogram.h" @@ -307,6 +309,7 @@ void ConnectionFactoryImpl::ConnectImpl() { RebuildNetworkSessionAuthCache(); int status = gcm_network_session_->proxy_service()->ResolveProxy( current_endpoint, + std::string(), net::LOAD_NORMAL, &proxy_info_, base::Bind(&ConnectionFactoryImpl::OnProxyResolveDone, @@ -530,7 +533,8 @@ int ConnectionFactoryImpl::ReconsiderProxyAfterError(int error) { } int status = gcm_network_session_->proxy_service()->ReconsiderProxyAfterError( - GetCurrentEndpoint(), net::LOAD_NORMAL, error, &proxy_info_, + GetCurrentEndpoint(), + std::string(), net::LOAD_NORMAL, error, &proxy_info_, base::Bind(&ConnectionFactoryImpl::OnProxyResolveDone, weak_ptr_factory_.GetWeakPtr()), &pac_request_, |