google_apis: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=rogerta@chromium.org, dcheng@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1727063003

Cr-Commit-Position: refs/heads/master@{#377739}

4 files changed, 6 insertions, 0 deletions

diff --git a/google_apis/gcm/engine/account_mapping.cc b/google_apis/gcm/engine/account_mapping.cc
index 57f8b80..411d177 100644
--- a/google_apis/gcm/engine/account_mapping.cc
+++ b/google_apis/gcm/engine/account_mapping.cc
@@ -64,6 +64,8 @@ bool StringToStatus(const std::string& status_str,
 AccountMapping::AccountMapping() : status(NEW) {
 }
 
+AccountMapping::AccountMapping(const AccountMapping& other) = default;
+
 AccountMapping::~AccountMapping() {
 }
 
diff --git a/google_apis/gcm/engine/account_mapping.h b/google_apis/gcm/engine/account_mapping.h
index ffed95c..bfd25a7 100644
--- a/google_apis/gcm/engine/account_mapping.h
+++ b/google_apis/gcm/engine/account_mapping.h
@@ -27,6 +27,7 @@ struct GCM_EXPORT AccountMapping {
   };
 
   AccountMapping();
+  AccountMapping(const AccountMapping& other);
   ~AccountMapping();
 
   // Serializes account mapping to string without |account_id|, |status| or
diff --git a/google_apis/gcm/engine/checkin_request.cc b/google_apis/gcm/engine/checkin_request.cc
index 5d47f7b..4ddcc8b 100644
--- a/google_apis/gcm/engine/checkin_request.cc
+++ b/google_apis/gcm/engine/checkin_request.cc
@@ -91,6 +91,8 @@ CheckinRequest::RequestInfo::RequestInfo(
       settings_digest(settings_digest),
       chrome_build_proto(chrome_build_proto) {}
 
+CheckinRequest::RequestInfo::RequestInfo(const RequestInfo& other) = default;
+
 CheckinRequest::RequestInfo::~RequestInfo() {}
 
 CheckinRequest::CheckinRequest(
diff --git a/google_apis/gcm/engine/checkin_request.h b/google_apis/gcm/engine/checkin_request.h
index f77e66d..d8767a2 100644
--- a/google_apis/gcm/engine/checkin_request.h
+++ b/google_apis/gcm/engine/checkin_request.h
@@ -46,6 +46,7 @@ class GCM_EXPORT CheckinRequest : public net::URLFetcherDelegate {
                 const std::map<std::string, std::string>& account_tokens,
                 const std::string& settings_digest,
                 const checkin_proto::ChromeBuildProto& chrome_build_proto);
+    RequestInfo(const RequestInfo& other);
     ~RequestInfo();
 
     // Android ID of the device.