diff options
author | dpranke <dpranke@chromium.org> | 2016-02-03 08:57:44 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-03 16:59:37 +0000 |
commit | 002f2226477126a477d38086b119073911fa231d (patch) | |
tree | af82ceffc1a92388390867d474e90f4c0073771d /google_apis | |
parent | 761098fba97c6ec094e241b61ecf879134ab7922 (diff) | |
download | chromium_src-002f2226477126a477d38086b119073911fa231d.zip chromium_src-002f2226477126a477d38086b119073911fa231d.tar.gz chromium_src-002f2226477126a477d38086b119073911fa231d.tar.bz2 |
Revert of Move gn _run target generation into test(). (patchset #1 id:1 of https://codereview.chromium.org/1653003006/ )
Reason for revert:
Broke angle_unittests_run, which doesn't follow the template:
https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/53646/steps/compile/logs/stdio
Original issue's description:
> Move gn _run target generation into test().
>
> TBR=brettw@chromium.org
> BUG=
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/6b1b03783b81ea27bb521c02aa84b74f06d6f71a
> Cr-Commit-Position: refs/heads/master@{#373232}
TBR=phosek@chromium.org,brettw@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1664653003
Cr-Commit-Position: refs/heads/master@{#373257}
Diffstat (limited to 'google_apis')
-rw-r--r-- | google_apis/BUILD.gn | 9 | ||||
-rw-r--r-- | google_apis/gcm/BUILD.gn | 9 |
2 files changed, 18 insertions, 0 deletions
diff --git a/google_apis/BUILD.gn b/google_apis/BUILD.gn index d491b48..46048ff 100644 --- a/google_apis/BUILD.gn +++ b/google_apis/BUILD.gn @@ -224,6 +224,15 @@ source_set("test_support") { } } +# TODO(GYP): Delete this after we've converted everything to GN. +# The _run targets exist only for compatibility w/ GYP. +group("google_apis_unittests_run") { + testonly = true + deps = [ + ":google_apis_unittests", + ] +} + test("google_apis_unittests") { sources = [ "gaia/gaia_auth_fetcher_unittest.cc", diff --git a/google_apis/gcm/BUILD.gn b/google_apis/gcm/BUILD.gn index f63aefb..30ab4a6 100644 --- a/google_apis/gcm/BUILD.gn +++ b/google_apis/gcm/BUILD.gn @@ -123,6 +123,15 @@ executable("mcs_probe") { ] } +# TODO(GYP): Delete this after we've converted everything to GN. +# The _run targets exist only for compatibility w/ GYP. +group("gcm_unit_tests_run") { + testonly = true + deps = [ + ":gcm_unit_tests", + ] +} + test("gcm_unit_tests") { sources = [ "base/mcs_message_unittest.cc", |