diff options
author | svaldez <svaldez@chromium.org> | 2015-11-19 08:27:30 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-11-19 16:28:09 +0000 |
commit | 969a51186f89a385a8f5bd9ddc49f35dccf9cdd2 (patch) | |
tree | 4e34164ddd2c7039be295c8ac8a95be7a7a95c25 /google_apis | |
parent | fa5a66979cdf91dc7c0cb79f54dda08254c343ec (diff) | |
download | chromium_src-969a51186f89a385a8f5bd9ddc49f35dccf9cdd2.zip chromium_src-969a51186f89a385a8f5bd9ddc49f35dccf9cdd2.tar.gz chromium_src-969a51186f89a385a8f5bd9ddc49f35dccf9cdd2.tar.bz2 |
Migrating tests to use EmbeddedTestServer (misc)
- Moving tests to use EmbeddedTestServer where possible.
- net::test_server::EmbeddedTestServer references to net::EmbeddedTestServer
- Using server.Start() instead of server.InitializeAndWaitUntilReady()
- Renaming test_server() to be spawned_test_server() or embedded_test_server()
- Enabling tests disabled due to SpawnedTestServer compatibility
BUG=496825
TBR=brettw@chromium.org,jochen@chromium.org
Review URL: https://codereview.chromium.org/1431653003
Cr-Commit-Position: refs/heads/master@{#360598}
Diffstat (limited to 'google_apis')
4 files changed, 8 insertions, 8 deletions
diff --git a/google_apis/drive/base_requests_server_unittest.cc b/google_apis/drive/base_requests_server_unittest.cc index e8da79d..b4285a0 100644 --- a/google_apis/drive/base_requests_server_unittest.cc +++ b/google_apis/drive/base_requests_server_unittest.cc @@ -45,7 +45,7 @@ class BaseRequestsServerTest : public testing::Test { message_loop_.task_runner(), kTestUserAgent)); - ASSERT_TRUE(test_server_.InitializeAndWaitUntilReady()); + ASSERT_TRUE(test_server_.Start()); test_server_.RegisterRequestHandler( base::Bind(&test_util::HandleDownloadFileRequest, test_server_.base_url(), @@ -58,7 +58,7 @@ class BaseRequestsServerTest : public testing::Test { } base::MessageLoopForIO message_loop_; // Test server needs IO thread. - net::test_server::EmbeddedTestServer test_server_; + net::EmbeddedTestServer test_server_; scoped_ptr<RequestSender> request_sender_; scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_; base::ScopedTempDir temp_dir_; diff --git a/google_apis/drive/base_requests_unittest.cc b/google_apis/drive/base_requests_unittest.cc index 42fa640..c296c67 100644 --- a/google_apis/drive/base_requests_unittest.cc +++ b/google_apis/drive/base_requests_unittest.cc @@ -115,7 +115,7 @@ class BaseRequestsTest : public testing::Test { message_loop_.task_runner(), std::string() /* custom user agent */)); - ASSERT_TRUE(test_server_.InitializeAndWaitUntilReady()); + ASSERT_TRUE(test_server_.Start()); test_server_.RegisterRequestHandler( base::Bind(&BaseRequestsTest::HandleRequest, base::Unretained(this))); } @@ -133,7 +133,7 @@ class BaseRequestsTest : public testing::Test { base::MessageLoopForIO message_loop_; scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_; scoped_ptr<RequestSender> sender_; - net::test_server::EmbeddedTestServer test_server_; + net::EmbeddedTestServer test_server_; net::HttpStatusCode response_code_; std::string response_body_; diff --git a/google_apis/drive/drive_api_requests_unittest.cc b/google_apis/drive/drive_api_requests_unittest.cc index 15cb7cc..817fffa 100644 --- a/google_apis/drive/drive_api_requests_unittest.cc +++ b/google_apis/drive/drive_api_requests_unittest.cc @@ -129,7 +129,7 @@ class DriveApiRequestsTest : public testing::Test { ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); - ASSERT_TRUE(test_server_.InitializeAndWaitUntilReady()); + ASSERT_TRUE(test_server_.Start()); test_server_.RegisterRequestHandler( base::Bind(&DriveApiRequestsTest::HandleChildrenDeleteRequest, base::Unretained(this))); @@ -183,7 +183,7 @@ class DriveApiRequestsTest : public testing::Test { } base::MessageLoopForIO message_loop_; // Test server needs IO thread. - net::test_server::EmbeddedTestServer test_server_; + net::EmbeddedTestServer test_server_; scoped_ptr<RequestSender> request_sender_; scoped_ptr<DriveApiUrlGenerator> url_generator_; scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_; diff --git a/google_apis/drive/files_list_request_runner_unittest.cc b/google_apis/drive/files_list_request_runner_unittest.cc index 94d7312..d8d8e78 100644 --- a/google_apis/drive/files_list_request_runner_unittest.cc +++ b/google_apis/drive/files_list_request_runner_unittest.cc @@ -73,7 +73,7 @@ class FilesListRequestRunnerTest : public testing::Test { test_server_.RegisterRequestHandler( base::Bind(&FilesListRequestRunnerTest::OnFilesListRequest, base::Unretained(this), test_server_.base_url())); - ASSERT_TRUE(test_server_.InitializeAndWaitUntilReady()); + ASSERT_TRUE(test_server_.Start()); runner_.reset(new FilesListRequestRunner( request_sender_.get(), @@ -117,7 +117,7 @@ class FilesListRequestRunnerTest : public testing::Test { base::MessageLoopForIO message_loop_; // Test server needs IO thread. scoped_ptr<RequestSender> request_sender_; - net::test_server::EmbeddedTestServer test_server_; + net::EmbeddedTestServer test_server_; scoped_ptr<FilesListRequestRunner> runner_; scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_; base::Closure on_completed_callback_; |