diff options
| author | thakis <thakis@chromium.org> | 2016-02-09 07:23:11 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-09 15:23:53 +0000 |
| commit | 9fb9c88c4101275f908f123ec0289d398adb0258 (patch) | |
| tree | bcf7cf940e79dfc14a454b19fe2697ff6fe49bbc /gpu/BUILD.gn | |
| parent | 6f45beb8dcf95618eeb09dbfcc82f53f786a60e9 (diff) | |
| download | chromium_src-9fb9c88c4101275f908f123ec0289d398adb0258.zip chromium_src-9fb9c88c4101275f908f123ec0289d398adb0258.tar.gz chromium_src-9fb9c88c4101275f908f123ec0289d398adb0258.tar.bz2 | |
Revert of command_buffer_gles2: Add test command_buffer_gles2_test for command_buffer_gles2 (patchset #8 id:140001 of https://codereview.chromium.org/1640243002/ )
Reason for revert:
This seems to not build in release component builds: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29/builds/7700/steps/compile/logs/stdio
FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True command_buffer_gles2_tests.exe "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:command_buffer_gles2_tests.exe @command_buffer_gles2_tests.exe.rsp" 1 mt.exe rc.exe "obj\gpu\command_buffer_gles2_tests.command_buffer_gles2_tests.exe.intermediate.manifest" obj\gpu\command_buffer_gles2_tests.command_buffer_gles2_tests.exe.generated.manifest ..\..\build\win\compatibility.manifest
command_buffer_gles2_tests.command_buffer_gles2_tests_main.obj : error LNK2019: unresolved external symbol "bool g_command_buffer_gles_has_atexit_manager" (?g_command_buffer_gles_has_atexit_manager@@3_NA) referenced in function _main
Original issue's description:
> command_buffer_gles2: Add test command_buffer_gles2_test for command_buffer_gles2
>
> Add test command_buffer_gles2_test for testing command_buffer_gles2
> library.
>
> Makes the gpu bots to build target, but the target is not run
> on any bot.
>
> As an example, fix a potential nullptr reference in eglInitialize
> and tests the problem.
>
> Adding the test runner would be useful in order to further develop
> command_buffer_gles2. One development direction of the library
> would be to extend it enough to support creating OpenGL ES 3.0
> context.
>
> BUG=581634
>
> Committed: https://crrev.com/ee2d13a54fc1de09762f1e5be97d6db44235fa80
> Cr-Commit-Position: refs/heads/master@{#374353}
TBR=piman@chromium.org,zmo@google.com,kbr@chromium.org,vmiura@chromium.org,kkinnunen@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581634
Review URL: https://codereview.chromium.org/1680743007
Cr-Commit-Position: refs/heads/master@{#374378}
Diffstat (limited to 'gpu/BUILD.gn')
| -rw-r--r-- | gpu/BUILD.gn | 35 |
1 files changed, 0 insertions, 35 deletions
diff --git a/gpu/BUILD.gn b/gpu/BUILD.gn index af33ed3..63447f1 100644 --- a/gpu/BUILD.gn +++ b/gpu/BUILD.gn @@ -60,8 +60,6 @@ shared_library("command_buffer_gles2") { "gles2_conform_support/egl/egl.cc", "gles2_conform_support/egl/surface.cc", "gles2_conform_support/egl/surface.h", - "gles2_conform_support/egl/test_support.cc", - "gles2_conform_support/egl/test_support.h", ] deps = [ @@ -83,39 +81,6 @@ shared_library("command_buffer_gles2") { } } -# GYP version: //gpu/gpu.gyp:command_buffer_gles2_tests -test("command_buffer_gles2_tests") { - sources = [ - "command_buffer/tests/command_buffer_gles2_tests_main.cc", - "command_buffer/tests/egl_test.cc", - ] - - deps = [ - ":command_buffer_gles2", - "//base", - "//base/test:test_support", - "//base/third_party/dynamic_annotations", - "//testing/gmock", - "//testing/gtest", - ] - - defines = [ - "COMMAND_BUFFER_GLES_LIB_SUPPORT_ONLY", - "EGLAPIENTRY=", - "EGLAPI=", - ] - - libs = [] - - if (is_android) { - libs += [ "android" ] - deps += [ "//ui/android:ui_java" ] - } - if (!is_component_build) { - configs += [ "//build/config/gcc:rpath_for_built_shared_libraries" ] - } -} - source_set("test_support") { testonly = true sources = [ |