diff options
| author | rdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-21 17:29:04 +0000 |
|---|---|---|
| committer | rdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-21 17:29:04 +0000 |
| commit | bb89057200c7da78309804a8dc5ab1bd8f109182 (patch) | |
| tree | 5eb9d81b4320a5bb90b2dbabe2e83061e4978547 /gpu/GLES2/gl2platform.h | |
| parent | d3b04abc5ce706d8950c2f6beb2aa438f1edcd5a (diff) | |
| download | chromium_src-bb89057200c7da78309804a8dc5ab1bd8f109182.zip chromium_src-bb89057200c7da78309804a8dc5ab1bd8f109182.tar.gz chromium_src-bb89057200c7da78309804a8dc5ab1bd8f109182.tar.bz2 | |
Fix locking in CookieMonster.
Specifically:
* Added assertions in most private methods of CookieMonster that the instance lock is held.
* Refactored locking out of FindCookiesForHostAndDomain and into
DeleteCookie(url,cookie_name) and GetCookiesWithOptions (its callers)
to protect DeleteCookie's call to InternalDeleteCookie.
* Protected SetCookieableSchemes() (public method that modifies
internal state directly).
* Shifted calls to HasCookieableScheme() around so that they were protected by the instance lock.
BUG=43188
TEST=Windows net_unittests ParsedCookieTest.*:CookieMonsterTest.* (Inserted assertions, confirmed crash in CookieMonsterTest.DeleteCookieByName, refactored, confirmed no failure). Windows net_perftests ParsedCookieTest.*:CookieMonsterTest.* run before and after change; noted minimal (but non-zero) performance degradation.
Review URL: http://codereview.chromium.org/2131002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47928 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu/GLES2/gl2platform.h')
0 files changed, 0 insertions, 0 deletions