diff options
author | zmo <zmo@chromium.org> | 2016-02-11 18:39:28 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-12 02:40:16 +0000 |
commit | 61fa1ce8644588b0f64adac210c8663b49acdeed (patch) | |
tree | f80eb2a83efe971d03f4af94a2023cddf162bf99 /gpu/command_buffer/client/gles2_implementation.cc | |
parent | 6e04bbb0982274e0a019d4295c8c8f1254c51bb4 (diff) | |
download | chromium_src-61fa1ce8644588b0f64adac210c8663b49acdeed.zip chromium_src-61fa1ce8644588b0f64adac210c8663b49acdeed.tar.gz chromium_src-61fa1ce8644588b0f64adac210c8663b49acdeed.tar.bz2 |
Further cleanup blink side WebGL validation.
1) Move tex target validation out of validateTexFunc().
This is because validateTexFunc doesn't know whether we should only
allow 2D target or 3D target, and I feel it's better not to add more
virtual functions if we have an alternative that's not too much code.
Because of this, we can re-enable two webgl 2 tests.
2) Remove compressed texture validation.
We do the same thing on GPU command buffer side.
I have to make some slight change so command buffer side aligns with
removed blink code for the s3tc test to pass.
3) Remove validating internalformat/format/type combination for
textures.
We do the same thing on GPU command buffer side.
4) Remove sampler state caching in WebGLTexture/WebGLSampler.
BUG=570453
TEST=webgl_conformance,webgl2_conformance
R=kbr@chromium.org,bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/1689313002
Cr-Commit-Position: refs/heads/master@{#375099}
Diffstat (limited to 'gpu/command_buffer/client/gles2_implementation.cc')
-rw-r--r-- | gpu/command_buffer/client/gles2_implementation.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc index a53b9b0..3a18ee5 100644 --- a/gpu/command_buffer/client/gles2_implementation.cc +++ b/gpu/command_buffer/client/gles2_implementation.cc @@ -2105,9 +2105,6 @@ void GLES2Implementation::CompressedTexImage2D( SetGLError(GL_INVALID_VALUE, "glCompressedTexImage2D", "border != 0"); return; } - if (height == 0 || width == 0) { - return; - } // If there's a pixel unpack buffer bound use it when issuing // CompressedTexImage2D. if (bound_pixel_unpack_transfer_buffer_id_) { @@ -2193,9 +2190,6 @@ void GLES2Implementation::CompressedTexImage3D( SetGLError(GL_INVALID_VALUE, "glCompressedTexImage3D", "border != 0"); return; } - if (height == 0 || width == 0 || depth == 0) { - return; - } // If there's a pixel unpack buffer bound use it when issuing // CompressedTexImage3D. if (bound_pixel_unpack_transfer_buffer_id_) { |