diff options
author | reveman <reveman@chromium.org> | 2015-10-19 16:38:48 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-10-19 23:39:22 +0000 |
commit | 44429f23f3899d52c9493c114ae9b62e1ddeb7af (patch) | |
tree | e74bae28607a9c238eaf3e3ec2c4f1466f7d61e3 /gpu/command_buffer/service/texture_manager_unittest.cc | |
parent | ca96543ef138fe76457b5103bb02eebfde401387 (diff) | |
download | chromium_src-44429f23f3899d52c9493c114ae9b62e1ddeb7af.zip chromium_src-44429f23f3899d52c9493c114ae9b62e1ddeb7af.tar.gz chromium_src-44429f23f3899d52c9493c114ae9b62e1ddeb7af.tar.bz2 |
Revert of ui: Move GLImage::BindTexImage fallback from GLImage implementations to GLES2CmdDecoder. (patchset #15 id:280001 of https://codereview.chromium.org/1401423003/ )
Reason for revert:
Causing android gpu bots to fail
Original issue's description:
> ui: Move GLImage::BindTexImage fallback from GLImage implementations to GLES2CmdDecoder.
>
> This allows the GPU service to properly track the memory usage
> image backed textures.
>
> It also reduces the complexity of GLImage implementations
> significantly and makes it easier to support format and
> buffer types that require a copy or conversion of data to
> be used for sampling.
>
> This change also includes a few minor GLImage cleanups such
> as removing gfx:: namespace prefix in places where it's not
> needed and making the CopyTexImage GLImage test not part of
> the core GLImage tests as it's optional to support that
> function.
>
> BUG=526298
> TEST=gl_tests --gtest_filter=GpuMemoryBuffer*, gpu_unittests, gl_unittests --gtest_filter=GLImage*
>
> Committed: https://crrev.com/ac2696e324bda3824952148f831e76a8b80594b3
> Cr-Commit-Position: refs/heads/master@{#354870}
TBR=dcastagna@chromium.org,ericrk@chromium.org,fsamuel@chromium.org,liberato@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526298
Review URL: https://codereview.chromium.org/1418483003
Cr-Commit-Position: refs/heads/master@{#354914}
Diffstat (limited to 'gpu/command_buffer/service/texture_manager_unittest.cc')
-rw-r--r-- | gpu/command_buffer/service/texture_manager_unittest.cc | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/gpu/command_buffer/service/texture_manager_unittest.cc b/gpu/command_buffer/service/texture_manager_unittest.cc index 516f478..90e90c4 100644 --- a/gpu/command_buffer/service/texture_manager_unittest.cc +++ b/gpu/command_buffer/service/texture_manager_unittest.cc @@ -1391,15 +1391,12 @@ TEST_F(TextureTest, GetLevelImage) { EXPECT_TRUE(texture->GetLevelImage(GL_TEXTURE_2D, 1) == NULL); // Set image. scoped_refptr<gfx::GLImage> image(new gfx::GLImageStub); - manager_->SetLevelImage(texture_ref_.get(), GL_TEXTURE_2D, 1, image.get(), - Texture::BOUND); + manager_->SetLevelImage(texture_ref_.get(), GL_TEXTURE_2D, 1, image.get()); EXPECT_FALSE(texture->GetLevelImage(GL_TEXTURE_2D, 1) == NULL); // Remove it. - manager_->SetLevelImage(texture_ref_.get(), GL_TEXTURE_2D, 1, nullptr, - Texture::UNBOUND); + manager_->SetLevelImage(texture_ref_.get(), GL_TEXTURE_2D, 1, NULL); EXPECT_TRUE(texture->GetLevelImage(GL_TEXTURE_2D, 1) == NULL); - manager_->SetLevelImage(texture_ref_.get(), GL_TEXTURE_2D, 1, image.get(), - Texture::UNBOUND); + manager_->SetLevelImage(texture_ref_.get(), GL_TEXTURE_2D, 1, image.get()); // Image should be reset when SetLevelInfo is called. manager_->SetLevelInfo(texture_ref_.get(), GL_TEXTURE_2D, 1, GL_RGBA, 2, 2, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, gfx::Rect(2, 2)); @@ -1740,8 +1737,7 @@ TEST_P(ProduceConsumeTextureTest, ProduceConsumeTextureWithImage) { scoped_refptr<gfx::GLImage> image(new gfx::GLImageStub); manager_->SetLevelInfo(texture_ref_.get(), target, 0, GL_RGBA, 0, 0, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, gfx::Rect()); - manager_->SetLevelImage(texture_ref_.get(), target, 0, image.get(), - Texture::BOUND); + manager_->SetLevelImage(texture_ref_.get(), target, 0, image.get()); GLuint service_id = texture->service_id(); Texture* produced_texture = Produce(texture_ref_.get()); @@ -2061,15 +2057,13 @@ TEST_F(SharedTextureTest, Images) { EXPECT_FALSE(texture_manager1_->HaveImages()); EXPECT_FALSE(texture_manager2_->HaveImages()); scoped_refptr<gfx::GLImage> image1(new gfx::GLImageStub); - texture_manager1_->SetLevelImage(ref1.get(), GL_TEXTURE_2D, 1, image1.get(), - Texture::BOUND); + texture_manager1_->SetLevelImage(ref1.get(), GL_TEXTURE_2D, 1, image1.get()); EXPECT_TRUE(ref1->texture()->HasImages()); EXPECT_TRUE(ref2->texture()->HasImages()); EXPECT_TRUE(texture_manager1_->HaveImages()); EXPECT_TRUE(texture_manager2_->HaveImages()); scoped_refptr<gfx::GLImage> image2(new gfx::GLImageStub); - texture_manager1_->SetLevelImage(ref1.get(), GL_TEXTURE_2D, 1, image2.get(), - Texture::BOUND); + texture_manager1_->SetLevelImage(ref1.get(), GL_TEXTURE_2D, 1, image2.get()); EXPECT_TRUE(ref1->texture()->HasImages()); EXPECT_TRUE(ref2->texture()->HasImages()); EXPECT_TRUE(texture_manager1_->HaveImages()); |