diff options
| author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-28 02:01:25 +0000 |
|---|---|---|
| committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-28 02:01:25 +0000 |
| commit | c4f92c721fb4dceca86b8de139b129ae6472e551 (patch) | |
| tree | 529982fb9b4b11ce97428ffc7c03833748694068 /gpu/command_buffer | |
| parent | fdb9eccabcda7e3682faef271df0759f33be583c (diff) | |
| download | chromium_src-c4f92c721fb4dceca86b8de139b129ae6472e551.zip chromium_src-c4f92c721fb4dceca86b8de139b129ae6472e551.tar.gz chromium_src-c4f92c721fb4dceca86b8de139b129ae6472e551.tar.bz2 | |
Only BookmarkBubbleView::ShowEditor with a valid parent, etc.
NULL check anchor_widget in BookmarkBubbleView::ShowEditor.
If NULL, don't show the editor, just apply edits and close.
Avoids a NULL AV and bringing up a modeless dialog.
Minor whitespace and comment updates.
Add debugging code to find the root cause of this state.
CRASHES on debug values reflect some possible culprits.
TODO(msw): Follow up to determine crash cause(s).
TODO(msw): Nix BubbleDelegateView::WindowClosing???
(overridden by subclasses... my bad advice from http://codereview.chromium.org/10204014/)
BUG=134504,105151,124310
TEST=none, less BookmarkBubbleView::ShowEditor crashes.
Review URL: https://chromiumcodereview.appspot.com/10662031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144646 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu/command_buffer')
0 files changed, 0 insertions, 0 deletions