diff options
author | kkinnunen <kkinnunen@nvidia.com> | 2015-07-14 04:08:34 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-07-14 11:09:10 +0000 |
commit | b959a8467d84feb3431809fe4abafb9649c44b24 (patch) | |
tree | ef570319a26e2efb29bd1d6767a2f0ed1f3d73d0 /gpu/skia_bindings | |
parent | a39e79ebcde16f7604bf5de6bed0c665c8afe5b0 (diff) | |
download | chromium_src-b959a8467d84feb3431809fe4abafb9649c44b24.zip chromium_src-b959a8467d84feb3431809fe4abafb9649c44b24.tar.gz chromium_src-b959a8467d84feb3431809fe4abafb9649c44b24.tar.bz2 |
command_buffer: Implement path rendering functions for CHROMIUM_path_rendering
Add support for path rendering functions with CHROMIUM_path_rendering in
gpu command buffer. CHROMIUM_path_rendering pseudo extension will use
NV_path_rendering (NVPR).
After this patch, CHROMIUM_path_rendering is able to draw solid color
paths.
Adds following functions to the command buffer:
glGenPathsCHROMIUM
glDeletePathsCHROMIUM
glIsPathCHROMIUM
glPathCommandsCHROMIUM
glPathParameterfCHROMIUM
glPathParameteriCHROMIUM
glPathStencilFuncCHROMIUM
glStencilFillPathCHROMIUM
glStencilStrokePathCHROMIUM
glCoverFillPathCHROMIUM
glCoverStrokePathCHROMIUM
glStencilThenCoverFillPathCHROMIUM
glStencilThenCoverStrokePathCHROMIUM
Noteworthy items:
NVPR has calls with multiple data arrays. These will be passed by
memcpy:ing the arrays into the same transfer buffer. The arrays
containing GLfloats are copied first, because floats have more strict
alignment needs than whatever is in the other array.
The functions exposed by the command buffer take in subset of the values
that plain NVPR functions accept. Also some functions do not take
exact same amount of parameters, rather only those parameters that
are expected to vary based on Skia implementation.
The change does not add vertexshader-less shader program support to the
command buffer. The caller is expected to use a dummy vertex
shader. NVPR calls will ignore the vertex shader.
Adds gpu::gles2::PathManager class that should be similar to other
resource manager classes. The intention is that paths can be shared in
similar manner as other resources.
Changes generator to generate feature_info check for Is -type of
functions.
Moves the path matrix related constants from glchromium.h to
gl2extchromium.h, the constants are not "normal" GLES constants, rather
they are part of the extension.
Skia will not yet use the extension, because texturing support and
instanced variants of the draw functions are not exposed by
CHROMIUM_path_rendering.
The extension will be available through flag --enable-gl-path-rendering
BUG=344330
Review URL: https://codereview.chromium.org/169403005
Cr-Commit-Position: refs/heads/master@{#338666}
Diffstat (limited to 'gpu/skia_bindings')
-rw-r--r-- | gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc | 23 |
1 files changed, 21 insertions, 2 deletions
diff --git a/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc b/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc index 36ff45b..024c9cc 100644 --- a/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc +++ b/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc @@ -146,8 +146,27 @@ GrGLInterface* CreateCommandBufferSkiaGLBinding() { functions->fBindUniformLocation = glBindUniformLocationCHROMIUM; functions->fBlitFramebuffer = glBlitFramebufferCHROMIUM; functions->fGenerateMipmap = glGenerateMipmap; - functions->fMatrixLoadf = glMatrixLoadfCHROMIUM; - functions->fMatrixLoadIdentity = glMatrixLoadIdentityCHROMIUM; + if (false) { + // These are disabled until the full extension is implemented. + // Otherwise the interface fails validation and the context can not + // be created. + functions->fMatrixLoadf = glMatrixLoadfCHROMIUM; + functions->fMatrixLoadIdentity = glMatrixLoadIdentityCHROMIUM; + functions->fPathCommands = glPathCommandsCHROMIUM; + functions->fPathParameteri = glPathParameteriCHROMIUM; + functions->fPathParameterf = glPathParameterfCHROMIUM; + functions->fGenPaths = glGenPathsCHROMIUM; + functions->fIsPath = glIsPathCHROMIUM; + functions->fDeletePaths = glDeletePathsCHROMIUM; + functions->fPathStencilFunc = glPathStencilFuncCHROMIUM; + functions->fStencilFillPath = glStencilFillPathCHROMIUM; + functions->fStencilStrokePath = glStencilStrokePathCHROMIUM; + functions->fCoverFillPath = glCoverFillPathCHROMIUM; + functions->fCoverStrokePath = glCoverStrokePathCHROMIUM; + functions->fStencilThenCoverFillPath = glStencilThenCoverFillPathCHROMIUM; + functions->fStencilThenCoverStrokePath = + glStencilThenCoverStrokePathCHROMIUM; + } return interface; } |