diff options
| author | mkwst <mkwst@chromium.org> | 2016-02-29 02:34:36 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-29 10:35:42 +0000 |
| commit | ce3eee6988a1d901f47f95cf192b77874b85bdb2 (patch) | |
| tree | 959d00188ccf161b83c9e560f50a94456a464334 /ios/chrome/browser | |
| parent | 82e898cb55f4ddb724ebd410dc76dbddd2bc34f4 (diff) | |
| download | chromium_src-ce3eee6988a1d901f47f95cf192b77874b85bdb2.zip chromium_src-ce3eee6988a1d901f47f95cf192b77874b85bdb2.tar.gz chromium_src-ce3eee6988a1d901f47f95cf192b77874b85bdb2.tar.bz2 | |
CREDENTIAL: Only toggle 'skip_zero_click' state if API is used.
Currently, we're toggling 'skip_zero_click' to 'false' if the user logs
in successfully after autofill. We should restrict that a bit to ensure
that the site understands the credential management API (and can therefore
be assumed to explain to us when the user signs out).
This patch adjusts the API's behavior to send the relevant PasswordForm
to the client whenever it could have been handed over but wasn't. Upon
successful autofill-based login with that same credential, the client is
responsible for toggling its 'skip_zero_click' value, and for popping up
the first-run experience if necessary.
BUG=587440
R=vasilii@chromium.org,vabr@chromium.org
Review URL: https://codereview.chromium.org/1735013004
Cr-Commit-Position: refs/heads/master@{#378190}
Diffstat (limited to 'ios/chrome/browser')
| -rw-r--r-- | ios/chrome/browser/passwords/ios_chrome_password_manager_client.h | 2 | ||||
| -rw-r--r-- | ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h b/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h index 7912ba7..4303c92 100644 --- a/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h +++ b/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h @@ -58,7 +58,7 @@ class IOSChromePasswordManagerClient password_manager::PasswordStore* GetPasswordStore() const override; void NotifyUserAutoSignin( ScopedVector<autofill::PasswordForm> local_forms) override; - void NotifyUserAutoSigninBlockedOnFirstRun( + void NotifyUserCouldBeAutoSignedIn( scoped_ptr<autofill::PasswordForm> form) override; void NotifySuccessfulLoginWithExistingPassword( const autofill::PasswordForm& form) override; diff --git a/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm b/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm index b26121d..8fb509f 100644 --- a/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm +++ b/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm @@ -100,7 +100,7 @@ PasswordStore* IOSChromePasswordManagerClient::GetPasswordStore() const { void IOSChromePasswordManagerClient::NotifyUserAutoSignin( ScopedVector<autofill::PasswordForm> local_forms) {} -void IOSChromePasswordManagerClient::NotifyUserAutoSigninBlockedOnFirstRun( +void IOSChromePasswordManagerClient::NotifyUserCouldBeAutoSignedIn( scoped_ptr<autofill::PasswordForm> form) {} void IOSChromePasswordManagerClient::NotifySuccessfulLoginWithExistingPassword( |