diff options
| author | marq <marq@chromium.org> | 2015-10-22 11:56:52 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-22 18:57:51 +0000 |
| commit | 3f28f31db31e6e79c07d4fe76130ff4ee7e3b652 (patch) | |
| tree | 64921e12351ac5aaea0bf5fd0ba28798c35b562c /ios/net | |
| parent | 3e345524dcd8570438433c17e2b6f28ec530058d (diff) | |
| download | chromium_src-3f28f31db31e6e79c07d4fe76130ff4ee7e3b652.zip chromium_src-3f28f31db31e6e79c07d4fe76130ff4ee7e3b652.tar.gz chromium_src-3f28f31db31e6e79c07d4fe76130ff4ee7e3b652.tar.bz2 | |
Clean up TODO(marq) in upstream code.
Removed obsolete TODOs
Replaced remaining items with bugs.
BUG=546140
Review URL: https://codereview.chromium.org/1417293002
Cr-Commit-Position: refs/heads/master@{#355591}
Diffstat (limited to 'ios/net')
| -rw-r--r-- | ios/net/clients/crn_forwarding_network_client_factory.h | 4 | ||||
| -rw-r--r-- | ios/net/clients/crn_network_client_protocol.h | 1 |
2 files changed, 0 insertions, 5 deletions
diff --git a/ios/net/clients/crn_forwarding_network_client_factory.h b/ios/net/clients/crn_forwarding_network_client_factory.h index 4a6ff47..06b0602 100644 --- a/ios/net/clients/crn_forwarding_network_client_factory.h +++ b/ios/net/clients/crn_forwarding_network_client_factory.h @@ -26,10 +26,6 @@ class URLRequest; // The expectation is that subclasses of this class will not be derived from; // if this becomes necessary, the unit tests for this class should be updated. -// TODO(marq): Investigate possible less bloated interfaces for this, where (for -// example) all clients are added to each request, and then the clients opt-out -// during the existing CRNNetworkClientProtocol calls. - // Return a client to handle any request. // Factories should implement this method only if their clients need to be able // to handle didFailWithError: calls that might originate before the native diff --git a/ios/net/clients/crn_network_client_protocol.h b/ios/net/clients/crn_network_client_protocol.h index aebd155..d000789 100644 --- a/ios/net/clients/crn_network_client_protocol.h +++ b/ios/net/clients/crn_network_client_protocol.h @@ -44,7 +44,6 @@ typedef base::Callback<void(bool auth_ok, // Corresponds to |-URLProtocol:didReceiveResponse:cacheStoragePolicy|. - (void)didReceiveResponse:(NSURLResponse*)response; // Corresponds to |-URLProtocol:wasRedirectedToRequest:redirectResponse|. -// TODO(marq): make |nativeRequest| a const ref. - (void)wasRedirectedToRequest:(NSURLRequest*)request nativeRequest:(net::URLRequest*)nativeRequest redirectResponse:(NSURLResponse*)redirectResponse; |