summaryrefslogtreecommitdiffstats
path: root/ios/web/net
diff options
context:
space:
mode:
authorstuartmorgan <stuartmorgan@chromium.org>2015-08-24 08:55:05 -0700
committerCommit bot <commit-bot@chromium.org>2015-08-24 15:55:36 +0000
commitb89310841ba07654c97802a5375dd1ae47e3529f (patch)
tree5e93ed4aa74c6d3af9e030b606d4d9db2eaaf50c /ios/web/net
parent01cb97b2e09618bbc3a60c7348f0a844eea20547 (diff)
downloadchromium_src-b89310841ba07654c97802a5375dd1ae47e3529f.zip
chromium_src-b89310841ba07654c97802a5375dd1ae47e3529f.tar.gz
chromium_src-b89310841ba07654c97802a5375dd1ae47e3529f.tar.bz2
Remove request group ID from UA with WKWebView
Without the network stack, there is no need to append a request group ID to the user agent. This removes it in a minimal way; once the WKWebView-with-network-stack config is removed it'll be easier to clean up the cruft. BUG=None Review URL: https://codereview.chromium.org/1310763002 Cr-Commit-Position: refs/heads/master@{#345078}
Diffstat (limited to 'ios/web/net')
-rw-r--r--ios/web/net/request_group_util.h1
-rw-r--r--ios/web/net/request_group_util.mm2
2 files changed, 3 insertions, 0 deletions
diff --git a/ios/web/net/request_group_util.h b/ios/web/net/request_group_util.h
index 525f2d0..071f51f 100644
--- a/ios/web/net/request_group_util.h
+++ b/ios/web/net/request_group_util.h
@@ -30,6 +30,7 @@ NSString* ExtractRequestGroupIDFromUserAgent(NSString* user_agent);
// Returns a new user agent, which is the result of the encoding of
// |request_group_id| in |base_user_agent|. The request group ID can be later
// extracted with ExtractRequestGroupIDFromUserAgent().
+// If request_group_id is nil, returns base_user_agent.
NSString* AddRequestGroupIDToUserAgent(NSString* base_user_agent,
NSString* request_group_id);
diff --git a/ios/web/net/request_group_util.mm b/ios/web/net/request_group_util.mm
index 9a41cef..5aecb10 100644
--- a/ios/web/net/request_group_util.mm
+++ b/ios/web/net/request_group_util.mm
@@ -65,6 +65,8 @@ NSString* ExtractRequestGroupIDFromUserAgent(NSString* user_agent) {
NSString* AddRequestGroupIDToUserAgent(NSString* base_user_agent,
NSString* request_group_id) {
+ if (!request_group_id)
+ return base_user_agent;
// TODO(blundell): Develop a long-term solution to this problem.
// crbug.com/329243
DCHECK([request_group_id length] >= kMinimumIDLength);