diff options
| author | pkl <pkl@chromium.org> | 2015-10-19 18:03:42 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-20 01:04:20 +0000 |
| commit | 56951cb94edd4aa9d3c32e67b121724612cdc11b (patch) | |
| tree | dac4d94a797e30da3d2245f4f110dfe46af4bffb /ios/web | |
| parent | d939a4518a20a4ac4d88f006b1b3ab6d49642616 (diff) | |
| download | chromium_src-56951cb94edd4aa9d3c32e67b121724612cdc11b.zip chromium_src-56951cb94edd4aa9d3c32e67b121724612cdc11b.tar.gz chromium_src-56951cb94edd4aa9d3c32e67b121724612cdc11b.tar.bz2 | |
Removed stale TODO for isStaticFileRequest.
The practice of allowing the loading of .{png,jpg,jpeg} files when
User-Agent is not available seems safe in theory and no problems observed
in practice. So, it's a good time to close out the bug and clean up
the TODO.
BUG=228603
Review URL: https://codereview.chromium.org/1411073002
Cr-Commit-Position: refs/heads/master@{#354942}
Diffstat (limited to 'ios/web')
| -rw-r--r-- | ios/web/web_state/ui/crw_static_file_web_view.mm | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/ios/web/web_state/ui/crw_static_file_web_view.mm b/ios/web/web_state/ui/crw_static_file_web_view.mm index e40a0af..0a11041 100644 --- a/ios/web/web_state/ui/crw_static_file_web_view.mm +++ b/ios/web/web_state/ui/crw_static_file_web_view.mm @@ -74,11 +74,8 @@ NSString* const kStaticFileUserAgent = @"UIWebViewForStaticFileContent"; } // If a request originated from another file:/// page, the User-Agent - // will not be there. To be safe, check that the request is for image + // is not available. In this case, check that the request is for image // resources only. - // TODO(pkl): This current test to allow nil User-Agent and images to - // be loaded. A more air-tight implementation should inline images as - // "data" instead. See crbug.com/228603 NSString* suffix = [[request URL] pathExtension]; return [@[ @"png", @"jpg", @"jpeg" ] containsObject:[suffix lowercaseString]]; } |