diff options
author | brucedawson <brucedawson@chromium.org> | 2015-10-29 18:28:16 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-10-30 01:29:47 +0000 |
commit | 0693ed787f6ffd2b248ef8cf2c0dc050a4e9d8b2 (patch) | |
tree | 001f7dc9f20ce530ee37680981415e9912d0bf10 /ios | |
parent | 2fa40f2cb37ef537d174e3852356ee8c257b7edf (diff) | |
download | chromium_src-0693ed787f6ffd2b248ef8cf2c0dc050a4e9d8b2.zip chromium_src-0693ed787f6ffd2b248ef8cf2c0dc050a4e9d8b2.tar.gz chromium_src-0693ed787f6ffd2b248ef8cf2c0dc050a4e9d8b2.tar.bz2 |
Get VS 2015 to use const int definitions
VC++ up to VS 2015 RTM does not require explicit storage allocation for
static const integers declared in classes. VS 2015 Update 1 requires
these storage definitions in some cases. It's unclear exactly what
cases - simple tests work with and without the explicit storage
allocation.
Many previous versions of VC++ have theoretically *allowed* a
definition to supply storage, but tests on VC++ 2013 show that this
doesn't actually work correctly - it leads to duplicate definition
errors. So, the change is scoped to VS 2015 only.
This changed was landed in the upstream protobuf repo:
https://github.com/google/protobuf/commit/a74e912a8be1274
With this change the chrome target builds with the latest VS 2015.
R=scottmg@chromium.org, pdr@chromium.org
BUG=440500
Review URL: https://codereview.chromium.org/1422453005
Cr-Commit-Position: refs/heads/master@{#357013}
Diffstat (limited to 'ios')
0 files changed, 0 insertions, 0 deletions