WebResourceService is no longer reference counted

WebResourceService was extending its own lifetime while network requests
were in progress. This was not needed, and made the lifetime management
of request contexts harder.

This CL removes this behavior and cancels the requests when the service
is deleted.
Finally, the virtual method GetRequestContext(), which was a workaround
for the lifetime issues, is removed.

BUG=447575

Review URL: https://codereview.chromium.org/872703003

Cr-Commit-Position: refs/heads/master@{#313254}

2 files changed, 1 insertions, 5 deletions

diff --git a/ios/chrome/browser/web_resource/ios_web_resource_service.cc b/ios/chrome/browser/web_resource/ios_web_resource_service.cc
index 5d538c9..44458bb7 100644
--- a/ios/chrome/browser/web_resource/ios_web_resource_service.cc
+++ b/ios/chrome/browser/web_resource/ios_web_resource_service.cc
@@ -40,6 +40,7 @@ IOSWebResourceService::IOSWebResourceService(
           last_update_time_pref_name,
           start_fetch_delay_ms,
           cache_update_delay_ms,
+          GetApplicationContext()->GetSystemURLRequestContext(),
           nullptr) {
 }
 
@@ -75,7 +76,3 @@ void IOSWebResourceService::ParseJSON(const std::string& data,
                  success_callback, error_callback),
       base::Bind(&RunClosure));
 }
-
-net::URLRequestContextGetter* IOSWebResourceService::GetRequestContext() {
-  return GetApplicationContext()->GetSystemURLRequestContext();
-}
diff --git a/ios/chrome/browser/web_resource/ios_web_resource_service.h b/ios/chrome/browser/web_resource/ios_web_resource_service.h
index c64de5d..fda5ec9 100644
--- a/ios/chrome/browser/web_resource/ios_web_resource_service.h
+++ b/ios/chrome/browser/web_resource/ios_web_resource_service.h
@@ -37,7 +37,6 @@ class IOSWebResourceService : public web_resource::WebResourceService {
   void ParseJSON(const std::string& data,
                  const SuccessCallback& success_callback,
                  const ErrorCallback& error_callback) override;
-  net::URLRequestContextGetter* GetRequestContext() override;
 
   DISALLOW_COPY_AND_ASSIGN(IOSWebResourceService);
 };