diff options
| author | erikchen <erikchen@chromium.org> | 2015-10-29 15:37:04 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-29 22:37:43 +0000 |
| commit | a03dde6fdcd0308e897995bf2c6d00615bcda3ef (patch) | |
| tree | c4de89ba410cd0d39ac0da947ce31b94227288d2 /ipc/attachment_broker_privileged_win_unittest.cc | |
| parent | a584b9ec2e70e2ea2a56ca9698596ad5e5afea81 (diff) | |
| download | chromium_src-a03dde6fdcd0308e897995bf2c6d00615bcda3ef.zip chromium_src-a03dde6fdcd0308e897995bf2c6d00615bcda3ef.tar.gz chromium_src-a03dde6fdcd0308e897995bf2c6d00615bcda3ef.tar.bz2 | |
IPC: Remove unnecessary conversions of BrokerableAttachment.
BrokerableAttachments are typically stored and passed around in a scoped_refptr.
There were several locations where they were being unnecessarily converted to a
raw pointer. This was probably responsible for a non-deterministic crash on GPU
bots (https://code.google.com/p/chromium/issues/detail?id=535711#c28), although
I haven't been able to reproduce the problem locally.
BUG=535711
Review URL: https://codereview.chromium.org/1414503009
Cr-Commit-Position: refs/heads/master@{#356968}
Diffstat (limited to 'ipc/attachment_broker_privileged_win_unittest.cc')
| -rw-r--r-- | ipc/attachment_broker_privileged_win_unittest.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/ipc/attachment_broker_privileged_win_unittest.cc b/ipc/attachment_broker_privileged_win_unittest.cc index 555262a..b0353d6 100644 --- a/ipc/attachment_broker_privileged_win_unittest.cc +++ b/ipc/attachment_broker_privileged_win_unittest.cc @@ -276,8 +276,9 @@ class MockBroker : public IPC::AttachmentBrokerUnprivilegedWin { public: MockBroker() {} ~MockBroker() override {} - bool SendAttachmentToProcess(IPC::BrokerableAttachment* attachment, - base::ProcessId destination_process) override { + bool SendAttachmentToProcess( + const scoped_refptr<IPC::BrokerableAttachment>& attachment, + base::ProcessId destination_process) override { return IPC::AttachmentBrokerUnprivilegedWin::SendAttachmentToProcess( attachment, base::Process::Current().Pid()); } |