diff options
| author | avi <avi@chromium.org> | 2015-07-30 12:40:37 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-30 19:41:17 +0000 |
| commit | 090599613215def05230b90969a5747f0f06315a (patch) | |
| tree | 07b1163a76aaab0b60a9fc95187bc57228452d6b /ipc/attachment_broker_unprivileged.cc | |
| parent | 2764561f205fa201f971477ae16405236f1c8b16 (diff) | |
| download | chromium_src-090599613215def05230b90969a5747f0f06315a.zip chromium_src-090599613215def05230b90969a5747f0f06315a.tar.gz chromium_src-090599613215def05230b90969a5747f0f06315a.tar.bz2 | |
Revert of ipc: Clean up interface of attachment broker. (patchset #5 id:80001 of https://codereview.chromium.org/1269553003/)
Reason for revert:
Causes failures in:
IPCAttachmentBrokerPrivilegedWinTest.SendHandle
IPCAttachmentBrokerPrivilegedWinTest.SendHandleToSelf
IPCAttachmentBrokerPrivilegedWinTest.SendHandleWithoutPermissions
on the Win7 Tests (dbg)(1) bot
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/40372/steps/ipc_tests/logs/stdio
Original issue's description:
> ipc: Clean up interface of attachment broker.
>
> AttachmentBrokerUnprivileged now has a method
> DesignateBrokerCommunicationChannel which is used by non-broker processes to
> designate an IPC::Channel as the communication medium for brokerable attachment
> messages. IPC::Channel has a new member attachment_broker_endpoint_ which causes
> it to pass all messages through the attachment broker before forwarding them to
> the listener.
>
> BUG=493414
>
> Committed: https://crrev.com/9a06836982214f2edced21bbd1615b49e7f231bf
> Cr-Commit-Position: refs/heads/master@{#341143}
TBR=tsepez@chromium.org,erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493414
Review URL: https://codereview.chromium.org/1259953005
Cr-Commit-Position: refs/heads/master@{#341171}
Diffstat (limited to 'ipc/attachment_broker_unprivileged.cc')
| -rw-r--r-- | ipc/attachment_broker_unprivileged.cc | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/ipc/attachment_broker_unprivileged.cc b/ipc/attachment_broker_unprivileged.cc index b84eea3..bc2eb5a 100644 --- a/ipc/attachment_broker_unprivileged.cc +++ b/ipc/attachment_broker_unprivileged.cc @@ -4,20 +4,10 @@ #include "ipc/attachment_broker_unprivileged.h" -#include "ipc/ipc_channel.h" - namespace IPC { AttachmentBrokerUnprivileged::AttachmentBrokerUnprivileged() {} AttachmentBrokerUnprivileged::~AttachmentBrokerUnprivileged() {} -void AttachmentBrokerUnprivileged::DesignateBrokerCommunicationChannel( - IPC::Channel* channel) { - DCHECK(channel); - DCHECK(!sender_); - sender_ = channel; - channel->set_attachment_broker_endpoint(true); -} - } // namespace IPC |