diff options
| author | tommycli@chromium.org <tommycli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-29 21:15:44 +0000 |
|---|---|---|
| committer | tommycli@chromium.org <tommycli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-29 21:15:44 +0000 |
| commit | ab25b33481907b1feef324889aacfcf92049e000 (patch) | |
| tree | ad8093749b2c2115f42e8af8bc49510c73a25dcc /ipc/file_descriptor_set_posix.h | |
| parent | d1f09fe57b851be9be710681c11a02ddddee242f (diff) | |
| download | chromium_src-ab25b33481907b1feef324889aacfcf92049e000.zip chromium_src-ab25b33481907b1feef324889aacfcf92049e000.tar.gz chromium_src-ab25b33481907b1feef324889aacfcf92049e000.tar.bz2 | |
Increase maximum file descriptors per IPC message on POSIX from 5 to 7.
On POSIX, the maximum number of file descriptors passable in an IPC message is controlled by a constant 'kMaxDescriptorsPerMessage'. It's currently set at 5. This patch makes it 7.
The Picasa album table reader utility process (https://codereview.chromium.org/18986012/) needs to pass 7 files to the utility process. This works on Windows, but fails on POSIX (Mac), due to the aforementioned limit. This CL increases this limit to 7, as well as adds some DLOG messages to give better info to developers who hit this limit.
ipc_channel_posix.cc seems to indicate adding extra file descriptors just makes the messages longer by an 'int' per file descriptor. Making the maximum even larger would be okay with me too.
BUG=
Review URL: https://chromiumcodereview.appspot.com/23534018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220371 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/file_descriptor_set_posix.h')
| -rw-r--r-- | ipc/file_descriptor_set_posix.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ipc/file_descriptor_set_posix.h b/ipc/file_descriptor_set_posix.h index de4c5c6..f9c6033 100644 --- a/ipc/file_descriptor_set_posix.h +++ b/ipc/file_descriptor_set_posix.h @@ -30,7 +30,7 @@ class IPC_EXPORT FileDescriptorSet // // In debugging mode, it's a fatal error to try and add more than this number // of descriptors to a FileDescriptorSet. - static const size_t kMaxDescriptorsPerMessage = 5; + static const size_t kMaxDescriptorsPerMessage = 7; // --------------------------------------------------------------------------- // Interfaces for building during message serialisation... |