summaryrefslogtreecommitdiffstats
path: root/ipc/handle_attachment_win.h
diff options
context:
space:
mode:
authorerikchen <erikchen@chromium.org>2015-08-19 17:59:13 -0700
committerCommit bot <commit-bot@chromium.org>2015-08-20 01:00:01 +0000
commite8e4f4fa67ee9db6c2910020ef49318e5df68481 (patch)
treec55abb9c58bab8564cb20c36e2c4887e0c5d095b /ipc/handle_attachment_win.h
parent0e70552cb63a7f64d4badcf70e3e25d256b31f24 (diff)
downloadchromium_src-e8e4f4fa67ee9db6c2910020ef49318e5df68481.zip
chromium_src-e8e4f4fa67ee9db6c2910020ef49318e5df68481.tar.gz
chromium_src-e8e4f4fa67ee9db6c2910020ef49318e5df68481.tar.bz2
IPC: Add attachment brokering support to the message header.
Message dispatch happens before message translation, and message dispatch requires that all brokered attachments have been received. This means that attachment brokering needs to function without message translation. This is accomplished by modifying the message header to include a new field num_brokered_attachments, and writing the attachment ids into the IPC Channel immediately following the pickled message itself. AttachmentBrokerPrivilegedWinUnittest was expanded to test ChannelReader in the receiving process. It is now a fully functional end-to-end test of attachment brokering. BUG=493414 Review URL: https://codereview.chromium.org/1286253002 Cr-Commit-Position: refs/heads/master@{#344389}
Diffstat (limited to 'ipc/handle_attachment_win.h')
-rw-r--r--ipc/handle_attachment_win.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/ipc/handle_attachment_win.h b/ipc/handle_attachment_win.h
index 127cd57..cd086b9 100644
--- a/ipc/handle_attachment_win.h
+++ b/ipc/handle_attachment_win.h
@@ -40,7 +40,6 @@ class IPC_EXPORT HandleAttachmentWin : public BrokerableAttachment {
explicit HandleAttachmentWin(const BrokerableAttachment::AttachmentId& id);
BrokerableType GetBrokerableType() const override;
- void PopulateWithAttachment(const BrokerableAttachment* attachment) override;
// Returns the wire format of this attachment.
WireFormat GetWireFormat(const base::ProcessId& destination) const;