diff options
| author | erikchen <erikchen@chromium.org> | 2015-08-21 17:26:36 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-22 00:27:24 +0000 |
| commit | 37a2e0b682555bf35852d707dbd74b68f345841f (patch) | |
| tree | 3d08086581676e7c7b86410b2b6cc5cd8bc305d1 /ipc/ipc.gyp | |
| parent | f98cee5f50d3aaa4cd30d40a96a2ab7968260e0e (diff) | |
| download | chromium_src-37a2e0b682555bf35852d707dbd74b68f345841f.zip chromium_src-37a2e0b682555bf35852d707dbd74b68f345841f.tar.gz chromium_src-37a2e0b682555bf35852d707dbd74b68f345841f.tar.bz2 | |
Reland #1: IPC: Add attachment brokering support to the message header.
This reland fixes a race condition in the unit test SendHandleTwice that caused
the test to flakily fail, mostly on XP machines. This reland also updates switch
statements to contain a block for the newly added enum
BrokerableAttachment::PLACEHOLDER, which was causing problems with the clang
Windows build.
> Message dispatch happens before message translation, and message dispatch
> requires that all brokered attachments have been received. This means that
> attachment brokering needs to function without message translation. This is
> accomplished by modifying the message header to include a new field
> num_brokered_attachments, and writing the attachment ids into the IPC Channel
> immediately following the pickled message itself.
>
> AttachmentBrokerPrivilegedWinUnittest was expanded to test ChannelReader in the
> receiving process. It is now a fully functional end-to-end test of attachment
> brokering.
>
> BUG=493414
TBR=tsepez@chromium.org
BUG=493414
Review URL: https://codereview.chromium.org/1303103002
Cr-Commit-Position: refs/heads/master@{#344933}
Diffstat (limited to 'ipc/ipc.gyp')
| -rw-r--r-- | ipc/ipc.gyp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/ipc/ipc.gyp b/ipc/ipc.gyp index fb64c32..00f58b4 100644 --- a/ipc/ipc.gyp +++ b/ipc/ipc.gyp @@ -59,6 +59,9 @@ 'ipc_sync_channel_unittest.cc', 'ipc_sync_message_unittest.cc', 'ipc_sync_message_unittest.h', + 'ipc_test_messages.h', + 'ipc_test_message_generator.cc', + 'ipc_test_message_generator.h', 'run_all_unittests.cc', 'sync_socket_unittest.cc', 'unix_domain_socket_util_unittest.cc', |