diff options
| author | erikchen <erikchen@chromium.org> | 2015-08-27 12:49:58 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-27 19:50:28 +0000 |
| commit | 06faf0c0fb1bc6bd173af6152b928e2c80ab8f78 (patch) | |
| tree | cfb938a5c8d9813000cbfefa65f30aaf89ac7b66 /ipc/ipc.gypi | |
| parent | 3055ce7afdf11650d499378cb62ede310dc16f94 (diff) | |
| download | chromium_src-06faf0c0fb1bc6bd173af6152b928e2c80ab8f78.zip chromium_src-06faf0c0fb1bc6bd173af6152b928e2c80ab8f78.tar.gz chromium_src-06faf0c0fb1bc6bd173af6152b928e2c80ab8f78.tar.bz2 | |
Revert of IPC: Add attachment brokering support to the message header. (patchset #3 id:40001 of https://codereview.chromium.org/1303103002/ )
Reason for revert:
Reverting on suspicion of causing crashes in Canary.
https://code.google.com/p/chromium/issues/detail?id=524032
Original issue's description:
> Reland #1: IPC: Add attachment brokering support to the message header.
>
> This reland fixes a race condition in the unit test SendHandleTwice that caused
> the test to flakily fail, mostly on XP machines. This reland also updates switch
> statements to contain a block for the newly added enum
> BrokerableAttachment::PLACEHOLDER, which was causing problems with the clang
> Windows build.
>
> > Message dispatch happens before message translation, and message dispatch
> > requires that all brokered attachments have been received. This means that
> > attachment brokering needs to function without message translation. This is
> > accomplished by modifying the message header to include a new field
> > num_brokered_attachments, and writing the attachment ids into the IPC Channel
> > immediately following the pickled message itself.
> >
> > AttachmentBrokerPrivilegedWinUnittest was expanded to test ChannelReader in the
> > receiving process. It is now a fully functional end-to-end test of attachment
> > brokering.
> >
> > BUG=493414
>
> TBR=tsepez@chromium.org
> BUG=493414
>
> Committed: https://crrev.com/37a2e0b682555bf35852d707dbd74b68f345841f
> Cr-Commit-Position: refs/heads/master@{#344933}
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493414
Review URL: https://codereview.chromium.org/1312433009
Cr-Commit-Position: refs/heads/master@{#345960}
Diffstat (limited to 'ipc/ipc.gypi')
| -rw-r--r-- | ipc/ipc.gypi | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/ipc/ipc.gypi b/ipc/ipc.gypi index dbcdec2..beb0a6a 100644 --- a/ipc/ipc.gypi +++ b/ipc/ipc.gypi @@ -87,8 +87,6 @@ 'param_traits_macros.h', 'param_traits_read_macros.h', 'param_traits_write_macros.h', - 'placeholder_brokerable_attachment.cc', - 'placeholder_brokerable_attachment.h', 'struct_constructor_macros.h', 'struct_destructor_macros.h', 'unix_domain_socket_util.cc', |