diff options
author | avi <avi@chromium.org> | 2015-07-30 12:40:37 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-07-30 19:41:17 +0000 |
commit | 090599613215def05230b90969a5747f0f06315a (patch) | |
tree | 07b1163a76aaab0b60a9fc95187bc57228452d6b /ipc/ipc_channel.h | |
parent | 2764561f205fa201f971477ae16405236f1c8b16 (diff) | |
download | chromium_src-090599613215def05230b90969a5747f0f06315a.zip chromium_src-090599613215def05230b90969a5747f0f06315a.tar.gz chromium_src-090599613215def05230b90969a5747f0f06315a.tar.bz2 |
Revert of ipc: Clean up interface of attachment broker. (patchset #5 id:80001 of https://codereview.chromium.org/1269553003/)
Reason for revert:
Causes failures in:
IPCAttachmentBrokerPrivilegedWinTest.SendHandle
IPCAttachmentBrokerPrivilegedWinTest.SendHandleToSelf
IPCAttachmentBrokerPrivilegedWinTest.SendHandleWithoutPermissions
on the Win7 Tests (dbg)(1) bot
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/40372/steps/ipc_tests/logs/stdio
Original issue's description:
> ipc: Clean up interface of attachment broker.
>
> AttachmentBrokerUnprivileged now has a method
> DesignateBrokerCommunicationChannel which is used by non-broker processes to
> designate an IPC::Channel as the communication medium for brokerable attachment
> messages. IPC::Channel has a new member attachment_broker_endpoint_ which causes
> it to pass all messages through the attachment broker before forwarding them to
> the listener.
>
> BUG=493414
>
> Committed: https://crrev.com/9a06836982214f2edced21bbd1615b49e7f231bf
> Cr-Commit-Position: refs/heads/master@{#341143}
TBR=tsepez@chromium.org,erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493414
Review URL: https://codereview.chromium.org/1259953005
Cr-Commit-Position: refs/heads/master@{#341171}
Diffstat (limited to 'ipc/ipc_channel.h')
-rw-r--r-- | ipc/ipc_channel.h | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h index a9f70b2..c5c46a7 100644 --- a/ipc/ipc_channel.h +++ b/ipc/ipc_channel.h @@ -165,7 +165,6 @@ class IPC_EXPORT Channel : public Sender { Listener* listener, AttachmentBroker* broker = nullptr); - Channel() : attachment_broker_endpoint_(false) {} ~Channel() override; // Connect the pipe. On the server side, this will initiate @@ -253,17 +252,6 @@ class IPC_EXPORT Channel : public Sender { static void NotifyProcessForkedForTesting(); #endif - void set_attachment_broker_endpoint(bool is_endpoint) { - attachment_broker_endpoint_ = is_endpoint; - } - - protected: - bool is_attachment_broker_endpoint() { return attachment_broker_endpoint_; } - - private: - // Whether this channel is used as an endpoint for sending and receiving - // brokerable attachment messages to/from the broker process. - bool attachment_broker_endpoint_; }; #if defined(OS_POSIX) |