IPC: Make ChannelReader inherit from SupportsAttachmentBrokering.

Each IPC::Channel will have a reference to an AttachmentBroker. This is
accomplished by requiring each of the Channel::Create methods to have a
|broker| parameter. For now, the |broker| parameter has a default value of
nullptr. This default parameter only exists so that this CL and subsequent
refactors can be decomposed into smaller CLs. The default parameter will be
removed once all callers of Channel::Create have been updated to pass in an
appropriate broker.

BUG=493414

Review URL: https://codereview.chromium.org/1185133006

Cr-Commit-Position: refs/heads/master@{#334699}

1 files changed, 25 insertions, 12 deletions

diff --git a/ipc/ipc_channel_common.cc b/ipc/ipc_channel_common.cc
index 23b85e2..5438c66 100644
--- a/ipc/ipc_channel_common.cc
+++ b/ipc/ipc_channel_common.cc
@@ -8,36 +8,49 @@ namespace IPC {
 
 // static
 scoped_ptr<Channel> Channel::CreateClient(
-    const IPC::ChannelHandle &channel_handle, Listener* listener) {
-  return Channel::Create(channel_handle, Channel::MODE_CLIENT, listener);
+    const IPC::ChannelHandle& channel_handle,
+    Listener* listener,
+    AttachmentBroker* broker) {
+  return Channel::Create(channel_handle, Channel::MODE_CLIENT, listener,
+                         broker);
 }
 
 // static
 scoped_ptr<Channel> Channel::CreateNamedServer(
-    const IPC::ChannelHandle &channel_handle, Listener* listener) {
-  return Channel::Create(channel_handle, Channel::MODE_NAMED_SERVER, listener);
+    const IPC::ChannelHandle& channel_handle,
+    Listener* listener,
+    AttachmentBroker* broker) {
+  return Channel::Create(channel_handle, Channel::MODE_NAMED_SERVER, listener,
+                         broker);
 }
 
 // static
 scoped_ptr<Channel> Channel::CreateNamedClient(
-    const IPC::ChannelHandle &channel_handle, Listener* listener) {
-  return Channel::Create(channel_handle, Channel::MODE_NAMED_CLIENT, listener);
+    const IPC::ChannelHandle& channel_handle,
+    Listener* listener,
+    AttachmentBroker* broker) {
+  return Channel::Create(channel_handle, Channel::MODE_NAMED_CLIENT, listener,
+                         broker);
 }
 
 #if defined(OS_POSIX)
 // static
 scoped_ptr<Channel> Channel::CreateOpenNamedServer(
-    const IPC::ChannelHandle &channel_handle, Listener* listener) {
-  return Channel::Create(channel_handle,
-                         Channel::MODE_OPEN_NAMED_SERVER,
-                         listener);
+    const IPC::ChannelHandle& channel_handle,
+    Listener* listener,
+    AttachmentBroker* broker) {
+  return Channel::Create(channel_handle, Channel::MODE_OPEN_NAMED_SERVER,
+                         listener, broker);
 }
 #endif
 
 // static
 scoped_ptr<Channel> Channel::CreateServer(
-    const IPC::ChannelHandle &channel_handle, Listener* listener) {
-  return Channel::Create(channel_handle, Channel::MODE_SERVER, listener);
+    const IPC::ChannelHandle& channel_handle,
+    Listener* listener,
+    AttachmentBroker* broker) {
+  return Channel::Create(channel_handle, Channel::MODE_SERVER, listener,
+                         broker);
 }
 
 Channel::~Channel() {